Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can polyfill references be removed? #100

Open
clintfred opened this issue Jun 4, 2021 · 1 comment
Open

Can polyfill references be removed? #100

clintfred opened this issue Jun 4, 2021 · 1 comment

Comments

@clintfred
Copy link
Contributor

clintfred commented Jun 4, 2021

When working on #97 I came across several references to polyfill as a fallback for cryptographic operations. I don't think these are probably needed anymore.

eg:

    return NativeAes.decryptDeviceAndSigningKeys(devicePrivateKey, signingPrivateKey, symmetricKey, iv).handleWith(() =>
        PolyfillAes.decryptDeviceAndSigningKeys(devicePrivateKey, signingPrivateKey, symmetricKey, iv)
    )

Maybe everything in the PolyFilAes file can be removed? Maybe sjcl can be removed?

@clintfred clintfred added Epic and removed Epic labels Jun 4, 2021
@skeet70
Copy link
Member

skeet70 commented Jan 2, 2024

https://caniuse.com/mdn-api_crypto_subtle

We should be able to remove the whole file. The NativeAes operations all use crypto.subtle which seems well supported at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants