Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocked Release Workflow #427

Open
NieraAI opened this issue Apr 25, 2024 · 2 comments
Open

Blocked Release Workflow #427

NieraAI opened this issue Apr 25, 2024 · 2 comments

Comments

@NieraAI
Copy link

NieraAI commented Apr 25, 2024

Hey, looks like github actions are failing and blocking the 5.12.0 release. I did a little bit of digging and jotted down a few things here:

  • ubuntu-latest: failing because the actions are configured to use node version 14 & min. version required by a dependency is 18.0.0
  • macos-latest: I'm not familiar with this error. Searching online shows it could be due to any one of a number of reasons. I didn't dig any further though since I think we probably should start by updating the node version first. I believe this will most likely bring up more issues with the action-electron-builder package. Especially since it's quite outdated and is probably incompatible with newer versions of node.

Few more things I noticed while digging:

  • actions/checkout and actions/setup-node are running v2. Latest is now v4.
  • the actions' node version is manually set to version 14 - but package.json sets the engines.node version to >=8.0.0. Perhaps it's better to have our node version in sync across the whole ecosystem? P.s. we can use the node-version-file key in our github actions and then point it at package.json or a .nvmrc file, for example.
  • We could stand to benefit from committing the package-lock.json file to the git history - c.f. https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json
  • This fork of action-electron-builder seems to be compatible with v20 of node. I haven't tested it, personally, but thought it was worth bringing up here.

Let me know if you need help investigating or applying any of these changes. For the latter, I'll likely need limited access to the repo to test & tweak by triggering the on release behaviour though.

@IrosTheBeggar
Copy link
Owner

Thanks for looking into this! I have fixed the pipelines and made some of your suggested updates. I'll leave this open while I implement the rest

@NieraAI
Copy link
Author

NieraAI commented May 7, 2024

Glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants