West Midlands | Data Flows | Iswat Bello

[Iswanna]

• Evidence that I have completed at least 6 katas in the Data Flows collection and at least 6 katas in the Array and Object Methods collection.

• A link to my GitHub repo for the “TV Show Project”.

• A link to my deployed Netlify site for the “TV Show Project”.

• A link to my level 400 pull requests for the “TV Show Project”.

• A link to my level 500 pull requests for the “TV Show Project”.

• A link to my completed pull request for “Book Library Project”, where I have responded to review feedback.

• A link to my issue for “LinkedIn Social Selling Index”. This issue show my current index and actions I will take to improve it.

• A screenshot of a video call showing that I took part in an online study session with at least one other trainee.

• A screenshot showing that I gave a demo in a demo session with particular members of staff present.

[cjyuan]

Handling of asynchronous calls in the TV Show app is not quite correct.

function fetchWithCache(url) {
  if (fetchCache.has(url)) return fetchCache.get(url);
  const p = fetch(url).then((r) => {
    // Throwing an error inside the callback function passed to then() 
    // only makes then() to return a promise that rejects to an error.
    if (!r.ok) throw new Error("Network error");   
    return r.json();
  });

  // On error (e.g., network temporarily down), p is a promise that rejects to an error.
  // If you save the rejected promise, then even when the network is restored later, 
  // subsequent request will always get the rejected promise.
  fetchCache.set(url, p);
  return p;
}

async/await syntax is usually "cleaner". You may want to explore it later.

async function fetchWithCache(url) {
  if (fetchCache.has(url)) return fetchCache.get(url);

  const result = await fetch(url);
  if (!result.ok)
    throw new Error("Network error");
  
  const data = await result.json();

  fetchCache.set(url, data);
  return data;
}

[Iswanna]

Thank you so much, @cjyuan, for the feedback. I’ll update the code to implement your suggestion.