Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindUserByEmail case sensitive??? #264

Open
Daher848 opened this issue Apr 17, 2019 · 3 comments
Open

FindUserByEmail case sensitive??? #264

Daher848 opened this issue Apr 17, 2019 · 3 comments

Comments

@Daher848
Copy link

So am I mistaken that these two lines wouldn't return the same user? And why the hell not?

SlackUser slackUser = session.findUserByEmail("[email protected]);
SlackUser slackUser = session.findUserByEmail("[email protected]);

So my active directory has a few different case combos...
[email protected]
[email protected]
[email protected]

And when looking up Slack users by email, it seems to have to match the primary email exactly, specifically talking about case. And I need this lookup to be case insensitive.

Am I totally wrong, or is there a way around this?

@sandeep-yerramsetty
Copy link

sandeep-yerramsetty commented Nov 1, 2021

@Daher848 this issue seems to be fixed already. Check out this PR: #227

The method findUserByEmail($email) is case insensitive.

@sandeep-yerramsetty
Copy link

I will write unit tests for this function to verify the behavior.

@sandeep-yerramsetty
Copy link

this test proves that this method is working as expected: #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants