Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adapt language strings to use new strFormat function #34

Open
ItsSim opened this issue Feb 20, 2022 · 0 comments
Open

[Feature] Adapt language strings to use new strFormat function #34

ItsSim opened this issue Feb 20, 2022 · 0 comments
Labels
enhancement New feature or request feature accepted Feature has been accepted good first issue Good for newcomers help wanted Extra attention is needed low priority Low priority

Comments

@ItsSim
Copy link
Owner

ItsSim commented Feb 20, 2022

Is your feature request related to a problem? Please describe.
In commit 4dac61e I introduced a new strFormat function in a new utils.js file, located in /src/fsolauncher/library/utils.js.

I adapted one of the language strings to utilize this function (across all languages):

uitext.json:

"FSO_FAILED_INSTALLATION": "Failed to install %s. Try again later.",

macextras-installer.js

this.createProgressItem( strFormat( global.locale.FSO_FAILED_INSTALLATION, 'macOS Extras' ), 100 );

But every other language string has not been adapted yet. Here's an example that could be changed:

uitext.json

"INS_IN": "Installing in", 

... should be "Installing in %s" instead!

macextras-installer.js

this.FSOLauncher.IPC.addProgressItem(
  'FSOProgressItem' + this.id,
  `${this.parentComponent} MacExtras`,
  global.locale.INS_IN + ' ' + this.path, // should be strFormat( global.locale.INS_IN, this.path ) instead!
  Message,
  Percentage
);

Describe the solution you'd like
Every language string should use string formatting if it is able to. Need to revise every string in the application.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@ItsSim ItsSim added help wanted Extra attention is needed good first issue Good for newcomers feature request This is a feature request feature accepted Feature has been accepted labels Feb 20, 2022
@ItsSim ItsSim changed the title [Windows/Mac] Adapt language strings to use new strFormat function. [Windows/Mac] Adapt language strings to use new strFormat function Feb 20, 2022
@ItsSim ItsSim added enhancement New feature or request and removed feature request This is a feature request labels Feb 20, 2022
@ItsSim ItsSim added the low priority Low priority label Aug 14, 2022
@ItsSim ItsSim changed the title [Windows/Mac] Adapt language strings to use new strFormat function [All platforms] Adapt language strings to use new strFormat function Apr 3, 2024
@ItsSim ItsSim changed the title [All platforms] Adapt language strings to use new strFormat function Adapt language strings to use new strFormat function Apr 3, 2024
@ItsSim ItsSim changed the title Adapt language strings to use new strFormat function [Feature] Adapt language strings to use new strFormat function Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature accepted Feature has been accepted good first issue Good for newcomers help wanted Extra attention is needed low priority Low priority
Projects
None yet
Development

No branches or pull requests

1 participant