Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce SP ABI standard layout #754

Open
mrwonko opened this issue Nov 22, 2015 · 2 comments
Open

Enforce SP ABI standard layout #754

mrwonko opened this issue Nov 22, 2015 · 2 comments

Comments

@mrwonko
Copy link
Contributor

mrwonko commented Nov 22, 2015

The SP ABI currently contains non-standard layout types (e.g. std::vector) which differ across compilers/compiler versions. Can't have those if we want SP code mods.

Types can be checked at compile time using std::is_standard_layout.

(Is there already an issue about this? We've certainly talked about it previously, but I can't remember where.)

@ensiform
Copy link
Member

Where is it used in the ABI?

@mrwonko
Copy link
Contributor Author

mrwonko commented Nov 23, 2015

CGhoul2Info_v parameter in G2API_SetSkin() & co, at the very least.

@mrwonko mrwonko mentioned this issue Mar 25, 2016
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants