Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we require @dtd-version? #113

Closed
Klortho opened this issue Sep 17, 2015 · 6 comments
Closed

Should we require @dtd-version? #113

Klortho opened this issue Sep 17, 2015 · 6 comments

Comments

@Klortho
Copy link
Member

Klortho commented Sep 17, 2015

See http://jatspan.org/niso/publishing-1.1d3/#p=attr-dtd-version.

This attribute is defined as "FIXED", which means:

  • The attribute is optional -- it doesn't have to be present in an instance document
  • If it is present, its value must be the exact same as that specified in the DTD, e.g. "1.1d3".

It's a nice attribute, because it enables consumers (bots) to determine the version of the schema that the document conforms to, without having to read the doctype declaration or any processing instructions. OTOH, making this attribute required by JATS4R would put an extra burden on the content providers. Then again, it's best practice, and I'd guess that most of them are doing it anyway.

@jats-laura
Copy link
Contributor

I'd guess that most of them are doing it anyway

I don't think they are, actually. PMC gets very little data with the attribute explicitly stated.

@hubgit
Copy link
Member

hubgit commented Sep 17, 2015

Presumably the intention is that the value is read from the DTD rather than the XML file, so there's no reason to add it to the XML.

However, if we're encouraging re-use in environments that don't use the DTD, it might make sense to require it. It would have to be accurate, though…

FWIW, PeerJ's articles do have this attribute set.

@Klortho
Copy link
Member Author

Klortho commented Sep 21, 2015

I think it's a good best practice. What if we made it a warning if the attribute is not present?

@Klortho
Copy link
Member Author

Klortho commented Oct 15, 2015

It came up in the call just now, that we can use @dtd-version in the Schematron, to determine which license rules to apply (see #50). That would simplify things quite a bit for us. And using the test that "what's good for us is good for reuse", suggests that we should require it.

@ahamelers
Copy link

There seemed to be widespread support to require it on the call. Can anyone
think of any compelling reason not to require it?

On Thu, Oct 15, 2015 at 3:03 PM, Chris Maloney [email protected]
wrote:

It came up in the call just now, that we can use @dtd-version in the
Schematron, to determine which license rules to apply (see #50
#50). That would
simplify things quite a bit for us. And using the test that "what's good
for us is good for reuse", suggests that we should require it.


Reply to this email directly or view it on GitHub
#113 (comment)
.

@Klortho
Copy link
Member Author

Klortho commented Mar 31, 2016

This is a warning if it is not there.

@Klortho Klortho closed this as completed Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants