Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Remove the unsecure prompt for password #56

Open
dan-forsberg opened this issue Dec 25, 2016 · 2 comments
Open

Remove the unsecure prompt for password #56

dan-forsberg opened this issue Dec 25, 2016 · 2 comments

Comments

@dan-forsberg
Copy link

Instead of asking the user for a password and doing things like echo $PASSWORD | sudo ... just do sudo .... Some users might've setup sudo to not require the password, so asking for a password is meaningless in those cases. Plus if sudo DOES require a password you only need to enter it once, and sudo has it cached.

Another gaping issue I discovered, as someone who's setup sudo to not prompt for a password, is that when the installation tried to install packages pacman did the regular ":: Proceed with installation? [Y/n] "... my password was printed as a response in clear text.

@JBakamovic
Copy link
Owner

Plus if sudo DOES require a password you only need to enter it once, and sudo has it cached.

Yes, you're right about this.

as someone who's setup sudo to not prompt for a password ... my password was printed as a response in clear text.

Not sure if I get this. You don't have a password set up but still it gets printed out? I don't run Arch on any of my machines but I haven't observed this kind of issue anywhere else (Fedora, Ubuntu).

To be honest I am not spending much time around the installation script. If you have some spare time to provide a fix, pull request will be more than welcome :)

@louwers
Copy link

louwers commented Mar 3, 2017

You can have a password set while not requiring a password to be used with sudo. Maybe that clears it up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants