Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the the max value is currently 3 999 999? #1

Open
rturk opened this issue Aug 19, 2017 · 1 comment
Open

Why the the max value is currently 3 999 999? #1

rturk opened this issue Aug 19, 2017 · 1 comment

Comments

@rturk
Copy link

rturk commented Aug 19, 2017

No description provided.

@JCMais
Copy link
Owner

JCMais commented Aug 19, 2017

https://github.com/JCMais/romanize-number/blob/master/main.js#L49

for numbers greater than 3999999 we break roman rules of not repeating the same algarism more than 3 times, or we need to add more dashes, which is not really documented, at least I could not find some reliable source about it. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants