Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run the action on comment/command instead of every push #6

Open
staabm opened this issue Sep 14, 2019 · 3 comments
Open

run the action on comment/command instead of every push #6

staabm opened this issue Sep 14, 2019 · 3 comments

Comments

@staabm
Copy link
Contributor

staabm commented Sep 14, 2019

Wouldn't it make sense to run the action based on a user command with a given test-url, like

/webpagetest https://www.mywebsite/my-deep-url/

That way we could test urls which are more related to a pull request (instead of measuring only a single „hardcode“ url)

inspiration can be taken from e.g. https://github.com/cirrus-actions/rebase which does that with a different command.

I have no experience with docker or authoring github actions, therefore won't tackle it myself in the next weeks/months though.

@JCofman
Copy link
Owner

JCofman commented Sep 17, 2019

That's a good idea I will see what I can do ;) @all-contributors please add @staabm for ideas

@allcontributors
Copy link
Contributor

@JCofman

I've put up a pull request to add @staabm! 🎉

@staabm
Copy link
Contributor Author

staabm commented Sep 17, 2019

In case its helpful I try to add something similar to another github action.
OskarStark/php-cs-fixer-ga#11

Maybe there is some room for inspiration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants