Skip to content

Commit 5520f74

Browse files
Fix tests for dask dataframe and delayed backends
1 parent 8a3e6ae commit 5520f74

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

kartothek/io/dask/delayed.py

+2
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ def update_dataset_from_delayed(
264264
sort_partitions_by=None,
265265
secondary_indices=None,
266266
factory=None,
267+
table_name=SINGLE_TABLE,
267268
):
268269
"""
269270
A dask.delayed graph to add and store a list of dictionaries containing
@@ -304,6 +305,7 @@ def update_dataset_from_delayed(
304305
df_serializer=df_serializer,
305306
dataset_uuid=dataset_uuid,
306307
sort_partitions_by=sort_partitions_by,
308+
dataset_table_name=table_name,
307309
)
308310

309311
return dask.delayed(update_dataset_from_partitions)(

kartothek/io/testing/update.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -656,7 +656,7 @@ def test_update_of_dataset_with_non_default_table_name(
656656
[df_update],
657657
store=store_factory,
658658
dataset_uuid=dataset_uuid,
659-
table="non-default-name",
659+
table_name="non-default-name",
660660
partition_on=["date"],
661661
)
662662
dm = DatasetMetadata.load_from_store(dataset_uuid, store_factory())

tests/io/dask/dataframe/test_update.py

+6
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@ def _update_dataset(partitions, *args, **kwargs):
3232
else:
3333
partitions = None
3434

35+
# Replace `table_name` with `table` keyword argument to enable shared test code
36+
# via `bound_update_dataset` fixture
37+
if "table_name" in kwargs:
38+
kwargs["table"] = kwargs["table_name"]
39+
del kwargs["table_name"]
40+
3541
ddf = update_dataset_from_ddf(partitions, *args, **kwargs)
3642

3743
s = pickle.dumps(ddf, pickle.HIGHEST_PROTOCOL)

0 commit comments

Comments
 (0)