Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflows for running gofmt and golint in PRs #10

Open
DelusionalOptimist opened this issue Oct 4, 2022 · 7 comments
Open

Add workflows for running gofmt and golint in PRs #10

DelusionalOptimist opened this issue Oct 4, 2022 · 7 comments
Assignees
@elle-Bee
Labels
CI/CD good first issue Good for newcomers hacktoberfest kind/child

Comments

@DelusionalOptimist
Copy link
Member

See #7
@DelusionalOptimist DelusionalOptimist mentioned this issue Oct 4, 2022
Open
@PankhudiB
Copy link

Hello @DelusionalOptimist , I would like to pick this up.

@arvindpunk
Copy link
Member

Could also add static-check while we're at it, helps with enforcing a standardized style for writing Go code.

@DelusionalOptimist
Copy link
Member Author

Could also add static-check while we're at it, helps with enforcing a standardized style for writing Go code.

Agreed ✔️

Sure @PankhudiB, go ahead!

@DelusionalOptimist
Copy link
Member Author

Hey @PankhudiB, how's the progress on this?

@PankhudiB
Copy link

Hey, Sorry to let you know but I am out sick since last couple of days. As much as I want to work on this I don't think I ll be able to recover soon. You can unassign me from this issue. :|

@elle-Bee
Copy link

elle-Bee commented Mar 7, 2023 •
edited
Loading

Hey @DelusionalOptimist should I make the gofmt and golint operations in the build file itself or should I make seperate yaml files for them?

@DelusionalOptimist
Copy link
Member Author

@elle-Bee feel free to create new files. It'll be convenient to have formatting/linting related workflows and build/tests separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elle-Bee elle-Bee

Labels
CI/CD good first issue Good for newcomers hacktoberfest kind/child
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PankhudiB @arvindpunk @DelusionalOptimist @elle-Bee