-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Allow file attachment into the comments editor (Markdown) #10559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello, I'm an undergraduate programming major that's eager to make my first GitHub contribution. Would I be able to claim this issue? Thanks! |
I'm thoroughly occupied with the other issue I claimed (#10558), so I "unassigned" myself on this one. I'm not going to work on it at all, so it is completely free for someone else to claim. |
Hi, I'm looking for an issue for my project. Would you mind assigning this issue to me? I will try to fix it. Thanks! |
Hello there, would you be able to assign this project to me? |
See step 5 on the issue description: Drag'n'drop from web browser. Additionally: drag''drop from the file system should also be possible. When drag'n'drop of a file, the ususal file attachment handling should be made. (which moves the file if it is outside, the functionality is there) Moreover, I think, it would be good if drag'n'drop from firefox, the file should also be linked. Then, one does not have issues at find-unlinked-files.
This is an additional wish, you can also implement that.
This is an additional wish, you can also implement that. |
Nice! You can open a PR if you want. It might be hard to discuss things with screenshots only.
See how it works in markdown: https://github.com/JabRef/jabref/blob/main/README.md. Click on "Raw" and see
no
The path needs to be relative. See also the handling of linked files. - Maybe, it is good to re-use the linked files functionality.
There is Resizable Image Extension
|
@JorECardenas even if you have dropped this issue, opening a pull-request would be nice, since you say you have solved the issue at least partially. Other people might pick it up from there. |
Hi, I made the PR draft #12193 of my attempt to add this feature, I hope it is helpful to the next person that works on this issue |
/assign-me |
/assign @eslamnumber |
👋 Hey @eslamnumber, thank you for your interest in this issue! 🎉 We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly. In case you encounter failing tests during development, please check our developer FAQs! Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback. Happy coding! 🚀 ⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 26 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment. |
Example: This shows that the "Comment" field supports markdown - and the rendering supports images (theoretically) Images can also be displayed: One neesd to investigate how local paths work in that markdown syntax. One might need to resolve the relative paths to an aboslute one.
|
- Implemented JabRef's download functionality to save images locally. - Inserted the image link into the comment field next to the cursor. - Updated 'Find unlinked files' to ignore images referenced in comments. - Ensured proper image saving in the directory configured for the .bib file. This fix improves image handling and aligns with expected behavior.
How to reproduce
.
Expectation:

appears in the editordev-ai-wide-10.png
exists next to the.bib
file (which is the file directory configured for the bib file)Actual behavior
File is attached
Additional Info
Note: Deep link to the image: https://www.sequoiacap.com/wp-content/uploads/sites/6/2023/03/dev-ai-wide-10.png?resize=1440,1400
TODOs
Background:
The text was updated successfully, but these errors were encountered: