Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Tag Field for Resolve strings and Do not wrap under Preferences -> Entry for #12550

Open
koppor opened this issue Feb 23, 2025 · 6 comments · May be fixed by #12592
Open

Use a Tag Field for Resolve strings and Do not wrap under Preferences -> Entry for #12550

koppor opened this issue Feb 23, 2025 · 6 comments · May be fixed by #12592
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: preferences component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Feb 23, 2025

Currently, it's not easy to see and distinguish the BIbTeX fields. It should use a TagField like in Autocompletion.

Current implementation

Image

Desired look and feel:

Image

Task

  1. Analyze how "Autocompletion" preferences works
  2. Port to "Entry > Affected fields" and "Entry > Do not wrap when saving"

Do not modify the preference object itself; "just" the UI

@koppor koppor added component: preferences component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Feb 23, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 23, 2025
@vi-anusha
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

👋 Hey @vi-anusha, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 15 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@vi-anusha vi-anusha linked a pull request Mar 2, 2025 that will close this issue
7 tasks
@vi-anusha
Copy link

Hi @koppor
I have submitted a PR to address this issue: #12592. Let me know if any changes are needed!

@koppor koppor moved this from Free to take to Assigned in Good First Issues Mar 2, 2025
@koppor koppor moved this from Assigned to In Progress in Good First Issues Mar 7, 2025
@koppor
Copy link
Member Author

koppor commented Mar 11, 2025

@vi-anusha We reviewed #12592. No reply from since one week. Do you still work on this? -- All in all, it is perceived impolite on my side that you push here with a comment, receive feedback and then disappear without any further notice.

@koppor koppor moved this from In Progress to Assigned in Good First Issues Mar 11, 2025
@koppor koppor moved this from Assigned to In Progress in Good First Issues Mar 13, 2025
@vi-anusha
Copy link

Hi @koppor, apologies for the delay. I’ve updated the PR based on the feedback and added comments where necessary. Let me know if anything still needs improvement.

@koppor
Copy link
Member Author

koppor commented Mar 13, 2025

Hi @koppor, apologies for the delay. I’ve updated the PR based on the feedback and added comments where necessary. Let me know if anything still needs improvement.

Please only comment here if there are several days passed and you did not get any feedback. The PRs are constantly monitored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: preferences component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants