From e36aec0db9287873791008266b1b29d6cc27c094 Mon Sep 17 00:00:00 2001 From: Yubo-Cao Date: Fri, 19 Sep 2025 14:37:20 -0400 Subject: [PATCH 1/4] fix: Slightly improved visual consistency of the CitationkeyTab --- .../jabref/gui/actions/StandardActions.java | 1 - .../keypattern/KeyPatternPropertiesView.java | 9 - .../CitationKeyPatternTab.java | 9 - .../jabref/gui/util/component/HelpButton.java | 24 +++ .../main/resources/org/jabref/gui/Base.css | 9 + .../keypattern/KeyPatternProperties.fxml | 3 +- .../CitationKeyPatternTab.fxml | 170 +++++++++++++----- 7 files changed, 162 insertions(+), 63 deletions(-) diff --git a/jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java b/jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java index cd5dccd7f6b..60826f083e1 100644 --- a/jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java +++ b/jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java @@ -181,7 +181,6 @@ public enum StandardActions implements Action { HELP(Localization.lang("Online help"), IconTheme.JabRefIcons.HELP, KeyBinding.HELP), HELP_GROUPS(Localization.lang("Open Help page"), IconTheme.JabRefIcons.HELP, KeyBinding.HELP), - HELP_KEY_PATTERNS(Localization.lang("Help on key patterns"), IconTheme.JabRefIcons.HELP, KeyBinding.HELP), HELP_REGEX_SEARCH(Localization.lang("Help on regular expression search"), IconTheme.JabRefIcons.HELP, KeyBinding.HELP), HELP_NAME_FORMATTER(Localization.lang("Help on Name Formatting"), IconTheme.JabRefIcons.HELP, KeyBinding.HELP), HELP_SPECIAL_FIELDS(Localization.lang("Help on special fields"), IconTheme.JabRefIcons.HELP, KeyBinding.HELP), diff --git a/jabgui/src/main/java/org/jabref/gui/libraryproperties/keypattern/KeyPatternPropertiesView.java b/jabgui/src/main/java/org/jabref/gui/libraryproperties/keypattern/KeyPatternPropertiesView.java index e391efb5370..0d1e2416d8e 100644 --- a/jabgui/src/main/java/org/jabref/gui/libraryproperties/keypattern/KeyPatternPropertiesView.java +++ b/jabgui/src/main/java/org/jabref/gui/libraryproperties/keypattern/KeyPatternPropertiesView.java @@ -1,16 +1,11 @@ package org.jabref.gui.libraryproperties.keypattern; import javafx.fxml.FXML; -import javafx.scene.control.Button; -import org.jabref.gui.actions.ActionFactory; -import org.jabref.gui.actions.StandardActions; import org.jabref.gui.commonfxcontrols.CitationKeyPatternsPanel; -import org.jabref.gui.help.HelpAction; import org.jabref.gui.libraryproperties.AbstractPropertiesTabView; import org.jabref.gui.libraryproperties.PropertiesTab; import org.jabref.gui.preferences.GuiPreferences; -import org.jabref.logic.help.HelpFile; import org.jabref.logic.l10n.Localization; import org.jabref.model.database.BibDatabaseContext; import org.jabref.model.entry.BibEntryTypesManager; @@ -20,7 +15,6 @@ public class KeyPatternPropertiesView extends AbstractPropertiesTabView implements PropertiesTab { - @FXML private Button keyPatternHelp; @FXML private CitationKeyPatternsPanel bibtexKeyPatternTable; @Inject private GuiPreferences preferences; @@ -44,9 +38,6 @@ public void initialize() { bibtexKeyPatternTable.patternListProperty().bindBidirectional(viewModel.patternListProperty()); bibtexKeyPatternTable.defaultKeyPatternProperty().bindBidirectional(viewModel.defaultKeyPatternProperty()); - - ActionFactory actionFactory = new ActionFactory(); - actionFactory.configureIconButton(StandardActions.HELP_KEY_PATTERNS, new HelpAction(HelpFile.CITATION_KEY_PATTERN, dialogService, preferences.getExternalApplicationsPreferences()), keyPatternHelp); } @Override diff --git a/jabgui/src/main/java/org/jabref/gui/preferences/citationkeypattern/CitationKeyPatternTab.java b/jabgui/src/main/java/org/jabref/gui/preferences/citationkeypattern/CitationKeyPatternTab.java index dac2489ca0e..288ddd4f28d 100644 --- a/jabgui/src/main/java/org/jabref/gui/preferences/citationkeypattern/CitationKeyPatternTab.java +++ b/jabgui/src/main/java/org/jabref/gui/preferences/citationkeypattern/CitationKeyPatternTab.java @@ -1,18 +1,13 @@ package org.jabref.gui.preferences.citationkeypattern; import javafx.fxml.FXML; -import javafx.scene.control.Button; import javafx.scene.control.CheckBox; import javafx.scene.control.RadioButton; import javafx.scene.control.TextField; -import org.jabref.gui.actions.ActionFactory; -import org.jabref.gui.actions.StandardActions; import org.jabref.gui.commonfxcontrols.CitationKeyPatternsPanel; -import org.jabref.gui.help.HelpAction; import org.jabref.gui.preferences.AbstractPreferenceTabView; import org.jabref.gui.preferences.PreferencesTab; -import org.jabref.logic.help.HelpFile; import org.jabref.logic.l10n.Localization; import org.jabref.model.entry.BibEntryTypesManager; @@ -31,7 +26,6 @@ public class CitationKeyPatternTab extends AbstractPreferenceTabView new HelpAction(helpFile, dialogService, externalApplicationsPreferences).execute()); } + + public final StringProperty helpUrlProperty() { + if (helpUrl == null) { + helpUrl = new SimpleStringProperty(this, "helpUrl"); + helpUrl.addListener((observable, oldValue, newValue) -> { + if (newValue != null && !newValue.isEmpty()) { + setHelpPage(newValue); + } + }); + } + return helpUrl; + } + + public final String getHelpUrl() { + return helpUrlProperty().get(); + } + + public final void setHelpUrl(String url) { + helpUrlProperty().set(url); + } } diff --git a/jabgui/src/main/resources/org/jabref/gui/Base.css b/jabgui/src/main/resources/org/jabref/gui/Base.css index cdb132504ad..82d4414c6d7 100644 --- a/jabgui/src/main/resources/org/jabref/gui/Base.css +++ b/jabgui/src/main/resources/org/jabref/gui/Base.css @@ -1410,6 +1410,15 @@ We want to have a look that matches our icons in the tool-bar */ -fx-background-color: -fx-control-inner-background; } +.innerGridPane { + -fx-hgap: 1em; + -fx-vgap: 1em; +} + +.prefIndent { + -fx-padding: 0 0 0 1.667em; +} + .code-area .text { -fx-fill: -fx-text-background-color; } diff --git a/jabgui/src/main/resources/org/jabref/gui/libraryproperties/keypattern/KeyPatternProperties.fxml b/jabgui/src/main/resources/org/jabref/gui/libraryproperties/keypattern/KeyPatternProperties.fxml index 6004240b2e1..c8fcc23c723 100644 --- a/jabgui/src/main/resources/org/jabref/gui/libraryproperties/keypattern/KeyPatternProperties.fxml +++ b/jabgui/src/main/resources/org/jabref/gui/libraryproperties/keypattern/KeyPatternProperties.fxml @@ -6,12 +6,13 @@ +