Revise log levels

Author: JacobHenner

examples/leaderelection.py

@@ -13,6 +13,7 @@
 # limitations under the License.
 
 import asyncio
+import logging
 import os
 import uuid
 
@@ -21,6 +22,8 @@
 from kubernetes_asyncio.leaderelection import electionconfig, leaderelection
 from kubernetes_asyncio.leaderelection.resourcelock.leaselock import LeaseLock
 
+logging.basicConfig(level=logging.INFO)
+
 
 async def main():
 

kubernetes_asyncio/leaderelection/leaderelection.py

@@ -22,7 +22,6 @@
 
 from .leaderelectionrecord import LeaderElectionRecord
 
-
 """
 This package implements leader election using an annotation in a Kubernetes
 object. The onstarted_leading coroutine is run as a task, which is cancelled if
@@ -73,7 +72,7 @@ async def run(self):
 
     async def acquire(self):
         # Follower
-        logging.info("%s is a follower", self.election_config.lock.identity)
+        logging.debug("%s is a follower", self.election_config.lock.identity)
         retry_period = self.election_config.retry_period
 
         while True:
@@ -86,7 +85,7 @@ async def acquire(self):
 
     async def renew_loop(self):
         # Leader
-        logging.info(
+        logging.debug(
             "Leader has entered renew loop and will try to update lease continuously"
         )
 
@@ -131,13 +130,14 @@ async def try_acquire_or_renew(self):
         # A lock is not created with that name, try to create one
         if not lock_status:
             if json.loads(old_election_record.body)["code"] != HTTPStatus.NOT_FOUND:
-                logging.info(
+                logging.error(
                     "Error retrieving resource lock %s as %s",
-                    self.election_config.lock.name, old_election_record.reason,
+                    self.election_config.lock.name,
+                    old_election_record.reason,
                 )
                 return False
 
-            logging.info(
+            logging.debug(
                 "%s is trying to create a lock",
                 leader_election_record.holder_identity,
             )
@@ -148,8 +148,8 @@ async def try_acquire_or_renew(self):
             )
 
             if not create_status:
-                logging.info(
-                    "%s Failed to create lock", leader_election_record.holder_identity
+                logging.error(
+                    "%s failed to create lock", leader_election_record.holder_identity
                 )
                 return False
 
@@ -178,7 +178,7 @@ async def try_acquire_or_renew(self):
             and self.observed_record.holder_identity
             != old_election_record.holder_identity
         ):
-            logging.info(
+            logging.debug(
                 "Leader has switched to %s", old_election_record.holder_identity
             )
 
@@ -196,8 +196,8 @@ async def try_acquire_or_renew(self):
             + self.election_config.lease_duration * 1000
             > int(now_timestamp * 1000)
         ):
-            logging.info(
-                "yet to finish lease_duration, lease held by %s and has not expired",
+            logging.debug(
+                "Yet to finish lease_duration, lease held by %s and has not expired",
                 old_election_record.holder_identity,
             )
             return False
@@ -218,15 +218,15 @@ async def update_lock(self, leader_election_record):
         )
 
         if not update_status:
-            logging.info(
+            logging.warning(
                 "%s failed to acquire lease", leader_election_record.holder_identity
             )
             return False
 
         self.observed_record = leader_election_record
         self.observed_time_milliseconds = int(time.time() * 1000)
-        logging.info(
-            "leader %s has successfully acquired lease",
+        logging.debug(
+            "Leader %s has successfully updated lease",
             leader_election_record.holder_identity,
         )
         return True

kubernetes_asyncio/leaderelection/resourcelock/configmaplock.py

@@ -105,8 +105,8 @@ async def create(self, name, namespace, election_record):
                 namespace, body, pretty=True
             )
             return True
-        except ApiException as e:
-            logging.info("Failed to create lock as %s", e)
+        except ApiException:
+            logging.exception("Failed to create lock")
             return False
 
     async def update(self, name, namespace, updated_record):
@@ -125,8 +125,8 @@ async def update(self, name, namespace, updated_record):
                 name=name, namespace=namespace, body=self.configmap_reference
             )
             return True
-        except ApiException as e:
-            logging.info("Failed to update lock as %s", e)
+        except ApiException:
+            logging.exception("Failed to update lock")
             return False
 
     def get_lock_object(self, lock_record):

kubernetes_asyncio/leaderelection/resourcelock/leaselock.py

@@ -69,8 +69,8 @@ async def create(self, name, namespace, election_record):
                 namespace, body, pretty=True
             )
             return True
-        except ApiException as e:
-            logging.info("Failed to create lock as %s", e)
+        except ApiException:
+            logging.exception("Failed to create lock")
             return False
 
     async def update(self, name, namespace, updated_record):
@@ -90,8 +90,8 @@ async def update(self, name, namespace, updated_record):
                 name=name, namespace=namespace, body=self.lease_reference
             )
             return True
-        except ApiException as e:
-            logging.info("Failed to update lock as %s", e)
+        except ApiException:
+            logging.exception("Failed to update lock")
             return False
 
     def update_lease(self, leader_election_record, current_spec=None):