Skip to content

Security review: cross-contract reentrancy checklist (all crates) #806

@Jagadeeshftw

Description

@Jagadeeshftw

Great issue: Security review: cross-contract reentrancy checklist (all crates)

Description

Produce a short security appendix listing reentrancy surfaces across program-escrow, bounty_escrow, soroban mirrors.

Requirements and context

Reference malicious_reentrant patterns where present.

Must be secure, tested, and documented
Should be efficient and easy to review

Suggested execution

Fork the repo and create a branch
git checkout -b feature/contracts-reentrancy-review

Implement changes

Review: program-escrow/src/reentrancy_guard.rs, bounty_escrow/contracts/escrow/src/reentrancy_guard.rs, soroban contracts
Write tests: extend reentrancy tests where gaps found
Add documentation: consolidated security notes (contracts-only)

Include Rust doc comments (///) on public items equivalent to NatSpec-style documentation
Validate security assumptions

Test and commit

Run tests: from contracts/ directory run cargo test (scope with -p grainlify-core, -p program-escrow, -p bounty-escrow, -p view-facade as appropriate). For Soroban crates under soroban/contracts/, run cargo test from that package workspace.
Cover edge cases
Include test output summary and security notes in the PR

Example commit message

docs(contracts): reentrancy checklist across crates

Guidelines

Minimum 95 percent test coverage for new or materially changed contract code
Clear documentation (module-level docs and targeted README sections where new surface area is introduced)
Timeframe: 96 hours

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions