Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrities are concatenated #96

Open
Shakeskeyboarde opened this issue Aug 21, 2022 · 5 comments
Open

Integrities are concatenated #96

Shakeskeyboarde opened this issue Aug 21, 2022 · 5 comments

Comments

@Shakeskeyboarde
Copy link

Description

When run multiple times, the lock file changes every time, because the integrity strings are concatenated to the old integrity value.

Suggested Solution

Replace the integrity value instead of adding to it.

Help Needed

N/A

@JamieMason
Copy link
Owner

Thanks for reporting, will take a look.

@JamieMason
Copy link
Owner

Do you have a fix for this in your rewrite @Shakeskeyboarde? No worries if not but may save me some time if so.

@Shakeskeyboarde
Copy link
Author

I'm not sure I have a fix exactly, but here's my lock file handler: https://github.com/Shakeskeyboarde/npm-offline-mirror/blob/main/src/lock.ts

@alltom
Copy link

alltom commented Feb 5, 2024

Besides the noisy diffs, does this cause any problems? I noticed this in a new project, where it's my first time using shrinkpack.

@JamieMason
Copy link
Owner

I don't think it causes problems no, it just may have more hashes in that it needs to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants