Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong type the copyright frame #1

Open
JeevanJames opened this issue May 5, 2018 · 0 comments
Open

Strong type the copyright frame #1

JeevanJames opened this issue May 5, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@JeevanJames
Copy link
Owner

Instead of having a string for the copyright value and expecting consumers to understand its conventions, use two properties for the year (integer) and the copyright message.

tag.Copyright.Year = 1977;
tag.Copyright.Message = "Aerosmith";

Since these two properties are mandatory, there would not be any default property, and hence no need for an implicit cast operator for the default value to frame instance.

I'm also not sure of the frame having the ability to output the complete copyright string (i.e. Copyright (c) 1977 Aerosmith). This is not localized and will not be useful for any language other than English. Instead, leave it to the consumer to construct the string.

However, as per the spec, it would be useful to have a read-only property that can combine the Year and Message properties correctly.

@JeevanJames JeevanJames added the enhancement New feature or request label May 5, 2018
@JeevanJames JeevanJames self-assigned this May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant