Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp the genre frame #2

Open
JeevanJames opened this issue May 5, 2018 · 1 comment
Open

Revamp the genre frame #2

JeevanJames opened this issue May 5, 2018 · 1 comment
Assignees
@JeevanJames
Labels
enhancement New feature or request
Milestone
v0.6.0 - Revamp e...

Comments

@JeevanJames
Copy link
Owner

JeevanJames commented May 5, 2018 •
edited

The genre frame currently exposes its data as a string, which is not really useful. It needs to be more strongly-typed.

  • Add enums for the ID3v1 genres as well as the Winamp extensions mentioned in the spec.
  • Since multiple genre values can be specified, make it a collection.
  • As per the ID3v2 spec, have special properties to indicate whether the track is a remix (RX) or a cover (CR).
@JeevanJames JeevanJames added the enhancement New feature or request label May 5, 2018
@JeevanJames JeevanJames self-assigned this May 5, 2018
@JeevanJames JeevanJames changed the title Revamp the genre tag Revamp the genre frame May 5, 2018
mibe added a commit to mibe/ID3-AutoGen that referenced this issue Aug 30, 2022
@mibe
Add support for setting the genre of the song.
27ab06f 
This also contains a workaround for JeevanJames/Id3#2
@mibe
Copy link

mibe commented Aug 31, 2022

I had the task to add genre support to my project, which uses ID3v1. I made an enum for that with all the Winamp extensions, if you want to copy it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeevanJames JeevanJames

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.0 - Revamp existing frames
Development

No branches or pull requests
2 participants
@mibe @JeevanJames