Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal Conversions Do Not Use Invariant Culture #16

Closed
JeffFerguson opened this issue Jul 16, 2018 · 1 comment
Closed

Decimal Conversions Do Not Use Invariant Culture #16

JeffFerguson opened this issue Jul 16, 2018 · 1 comment
Labels
ready for next release

Comments

@JeffFerguson
Copy link
Owner

JeffFerguson commented Jul 16, 2018 •
edited
Loading

Bug report from a comment on Issue 12:

For instance you provided "https://.../msft-20111231.xml", Gepsio throws an exception while converting "1.0200" to decimal in CalculationArc.cs\CalculationArc(INode CalculationArcNode).
This happens because of dot seperator.
Solution: Use Convert.ToDecimal(OrderString, System.Globalization.CultureInfo.InvariantCulture);
After making this changes, Gepsio works fine and shows labels for instance you provided.

Gepsio should be checked to ensure that all decimal conversions use invariant culture settings.
cjundt added a commit to cjundt/gepsio that referenced this issue Oct 23, 2019
@cjundt
Unit tests for issue JeffFerguson#16.
e030cdd
@cjundt cjundt mentioned this issue Oct 23, 2019
Merged
@cjundt
Copy link
Contributor

cjundt commented Oct 29, 2019

Fixed in pull request #30.

JeffFerguson added a commit that referenced this issue Dec 21, 2019
@JeffFerguson
Merge pull request #30 from cjundt/fix16
bf99c72 
Fixes issue #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready for next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeffFerguson @cjundt