Refactored some attribute classes and added extended property type validation

Author: Thomas Hummes

Attributes/LimitAttribute.cs

@@ -7,32 +7,32 @@ public class LimitAttribute : PropertyAttribute
     {
         public enum Mode { LimitLower, LimitUpper, LimitBoth }
 
-        public Mode LimitMode;
+        private readonly Mode _limitMode;
 
-        public int LowerLimit;
-        public int UpperLimit;
+        private readonly int _lowerLimit;
+        private readonly int _upperLimit;
 
         public LimitAttribute(int lowerLimit) : this(Mode.LimitLower, lowerLimit, int.MaxValue) { }
 
         public LimitAttribute(int lowerLimit, int upperLimit) : this(Mode.LimitLower, lowerLimit, upperLimit) { }
 
-        public LimitAttribute(Mode mode, int lowerLimit, int upperLimit)
+        private LimitAttribute(Mode mode, int lowerLimit, int upperLimit)
         {
-            LimitMode = mode;
-            LowerLimit = lowerLimit;
-            UpperLimit = upperLimit;
+            _limitMode = mode;
+            _lowerLimit = lowerLimit;
+            _upperLimit = upperLimit;
         }
 
         public int Limit(int value)
         {
-            switch (LimitMode)
+            switch (_limitMode)
             {
                 case Mode.LimitLower:
-                    return Mathf.Clamp(value, LowerLimit, int.MaxValue);
+                    return Mathf.Clamp(value, _lowerLimit, int.MaxValue);
                 case Mode.LimitUpper:
-                    return Mathf.Clamp(value, int.MinValue, UpperLimit);
+                    return Mathf.Clamp(value, int.MinValue, _upperLimit);
                 case Mode.LimitBoth:
-                    return Mathf.Clamp(value, LowerLimit, UpperLimit);
+                    return Mathf.Clamp(value, _lowerLimit, _upperLimit);
                 default:
                     throw new ArgumentOutOfRangeException();
             }

Editor/PropertyDrawer/LayerPropertyDrawer.cs

@@ -8,6 +8,12 @@ public class LayerPropertyDrawer : PropertyDrawer
     {
         public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
         {
+            if (property.propertyType != SerializedPropertyType.Integer)
+            {
+                Debug.LogWarning("LayerAttribute can only be applied on integer properties/fields");
+                return;
+            }
+
             property.intValue = EditorGUI.LayerField(position, property.name, property.intValue);
         }
     }

Editor/PropertyDrawer/LimitPropertyDrawer.cs

@@ -8,6 +8,12 @@ public class LimitPropertyDrawer : PropertyDrawer
     {
         public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
         {
+            if (property.propertyType != SerializedPropertyType.Integer)
+            {
+                Debug.LogWarning("LimitAttribute can only be applied on integer properties/fields");
+                return;
+            }
+
             LimitAttribute limiter = attribute as LimitAttribute;
             property.intValue = limiter.Limit(EditorGUI.IntField(position, property.name, property.intValue));
         }

Editor/PropertyDrawer/SortingLayerPropertyDrawer.cs

@@ -12,7 +12,7 @@ public override void OnGUI(Rect position, SerializedProperty property, GUIConten
         {
             if (property.propertyType != SerializedPropertyType.Integer)
             {
-                // Integer is expected. Everything else is ignored.
+                Debug.LogWarning("SortingLayerAttributes can only be applied on integer properties/fields");
                 return;
             }
             EditorGUI.LabelField(position, label);

Editor/PropertyDrawer/TagPropertyDrawer.cs

@@ -8,6 +8,12 @@ public class TagPropertyDrawer : PropertyDrawer
     {
         public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
         {
+            if (property.propertyType != SerializedPropertyType.String)
+            {
+                Debug.LogWarning("TagAttribute can only be applied on string properties/fields");
+                return;
+            }
+
             property.stringValue = EditorGUI.TagField(position, property.name, property.stringValue);
         }
     }