Fix CI complaints

Author: nathanwbrei

src/libraries/JANA/Components/JHasInputs.h

@@ -288,7 +288,7 @@ struct JHasInputs {
                 facset->Print();
                 throw JException("Databundle with unique name '%s' does not inherit from JPodioDatabundle", m_databundle_name.c_str());
             }
-            m_data = dynamic_cast<const PodioT::collection_type*>(typed_databundle->GetCollection());
+            m_data = dynamic_cast<const typename PodioT::collection_type*>(typed_databundle->GetCollection());
             if (m_data == nullptr) {
                 throw JException("Databundle with unique name '%s' does not contain %s", m_databundle_name.c_str(), JTypeInfo::demangle<typename PodioT::collection_type>().c_str());
             }
@@ -448,7 +448,7 @@ struct JHasInputs {
                         facset->Print();
                         throw JException("Databundle with name '%s' does not inherit from JPodioDatabundle", short_or_unique_name.c_str());
                     }
-                    auto* typed_collection = dynamic_cast<const PodioT::collection_type*>(typed_databundle->GetCollection());
+                    auto* typed_collection = dynamic_cast<const typename PodioT::collection_type*>(typed_databundle->GetCollection());
                     if (typed_collection == nullptr) {
                         throw JException("Databundle with unique name '%s' does not contain %s", short_or_unique_name.c_str(), JTypeInfo::demangle<typename PodioT::collection_type>().c_str());
                     }

src/libraries/JANA/Components/JPodioOutput.h

@@ -145,14 +145,38 @@ class VariadicPodioOutput : public JHasOutputs::VariadicOutputBase {
 public:
     VariadicPodioOutput(JHasOutputs* owner, std::vector<std::string> default_collection_names={}) {
         owner->RegisterOutput(this);
-        this->m_is_variadic = true;
         for (const std::string& name : default_collection_names) {
-            auto coll = std::make_unique<JPodioDatabundle>();
-            coll->SetUniqueName(name);
-            coll->SetTypeName(JTypeInfo::demangle<PodioT>());
-            m_transient_collections.push_back(std::move(coll));
+            auto databundle = new JPodioDatabundle;
+            databundle->SetUniqueName(name);
+            databundle->SetTypeName(JTypeInfo::demangle<PodioT>());
+            databundle->SetTypeIndex(std::type_index(typeid(PodioT)));
+            m_databundles.push_back(databundle);
+            m_transient_collections.push_back(std::make_unique<typename PodioT::collection_type>());
         }
-        for (auto& coll_name : this->collection_names) {
+    }
+
+    void SetShortNames (std::vector<std::string> short_names) override {
+        m_databundles.clear();
+        m_transient_collections.clear();
+        for (const std::string& name : short_names) {
+            auto databundle = new JPodioDatabundle;
+            databundle->SetShortName(name);
+            databundle->SetTypeName(JTypeInfo::demangle<PodioT>());
+            databundle->SetTypeIndex(std::type_index(typeid(PodioT)));
+            m_databundles.push_back(databundle);
+            m_transient_collections.push_back(std::make_unique<typename PodioT::collection_type>());
+        }
+    }
+
+    void SetUniqueNames(std::vector<std::string> unique_names) override {
+        m_databundles.clear();
+        m_transient_collections.clear();
+        for (const std::string& name : unique_names) {
+            auto databundle = new JPodioDatabundle;
+            databundle->SetShortName(name);
+            databundle->SetTypeName(JTypeInfo::demangle<PodioT>());
+            databundle->SetTypeIndex(std::type_index(typeid(PodioT)));
+            m_databundles.push_back(databundle);
             m_transient_collections.push_back(std::make_unique<typename PodioT::collection_type>());
         }
     }

src/libraries/JANA/JFactoryGenerator.h

@@ -6,8 +6,8 @@
 
 #include <JANA/JFactorySet.h>
 #include <JANA/Utils/JTypeInfo.h>
+#include <JANA/JApplicationFwd.h>
 
-class JApplication;
 
 class JFactoryGenerator {