-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter is private in FiducialFilter #309
Comments
Same for PhotonGBTFilter |
Also PhotonGBTFilter::GetCaloMap would be useful as public |
These methods are We could make these methods Let me know what you prefer; if you were to use these functions in I'm not sure when I'll have time to make vector action functions, but contributions are always welcome. |
In clas12root the user works with region_particle pointers, which contain pointers to the relevent banks. The user is supplied with a vector of region_particles in the event loop to do their analysis. In the clas12root iguana Filter interface the vector of particles is looped over and if a particle fails the filter it is removed from the vector. After filtering the user will continue their analysis as before. For example FiducialFilter, https://github.com/dglazier/clas12root/blob/iguana_filter/iguana/Filters.h#L76 And a functions which performs the loop over all particles via a utility function, https://github.com/dglazier/clas12root/blob/iguana_filter/iguana/Filters.h#L95 After calling this latter function in the event loop they will have access to the filtered particles only. For this to be able to work clas12root needs to be able to access the currently private data members. |
In addition we now have private functions which must be called prior to the action. e.g. ZVertexFilter::Reload |
Closing, since this is a duplicate of #227. I prefer we make proper action functions; a few other algorithms need them too.
Call |
Action functions should be available for users.
Can we make FiducialFilter::Filter public ?
The text was updated successfully, but these errors were encountered: