Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhotonGBTFilter models #310

Open
dglazier opened this issue Nov 20, 2024 · 8 comments · May be fixed by #311
Open

PhotonGBTFilter models #310

dglazier opened this issue Nov 20, 2024 · 8 comments · May be fixed by #311

Comments

@dglazier
Copy link
Contributor

When trying to run this code with clas12root it needs the path to the models :

$IGUANA/src/iguana/algorithms/clas12/PhotonGBTFilter/

For #include "models/*"

Can these be copied to the iguana/include directory or something similar.
At the moment I can add the path with gInterpreter->AddIncludePath , but that assumes I can use $HIPO/../src/etc where $HIPO is the install directory and this is not garaunteed.
Cheers
Derek

@github-project-automation github-project-automation bot moved this to Unsorted in Iguana Nov 20, 2024
c-dilks added a commit that referenced this issue Nov 20, 2024
Instead, include them in the source file, so that the models don't need
to be installed (they are just in the library).

Closes #310
@c-dilks c-dilks linked a pull request Nov 20, 2024 that will close this issue
@c-dilks
Copy link
Member

c-dilks commented Nov 20, 2024

I chose a different approach in #311. Let me know if this works for you!

@c-dilks
Copy link
Member

c-dilks commented Nov 26, 2024

@dglazier do you need this resolved before we tag iguana v0.8.0?

@dglazier
Copy link
Contributor Author

@c-dilks currently I cannot test this until the various methods are public.

@dglazier
Copy link
Contributor Author

Should I just make a branch and make the necessary changes to get it running in clas12root ?

@c-dilks
Copy link
Member

c-dilks commented Nov 26, 2024

I'll send you an email with more details. This algorithm has no action functions yet, so clas12root's iguana wrapper cannot use it at the moment.

@c-dilks
Copy link
Member

c-dilks commented Nov 26, 2024

You're welcome to make a testing branch/PR here, that's always welcome.

@dglazier
Copy link
Contributor Author

It has a filter function which clas12root could use,

https://github.com/dglazier/clas12root/blob/iguana_filter/iguana/Filters.h#L106

@c-dilks
Copy link
Member

c-dilks commented Nov 26, 2024

It has a filter function which clas12root could use,

https://github.com/dglazier/clas12root/blob/iguana_filter/iguana/Filters.h#L106

That is not an action function, despite the documentation; sorry for the misunderstanding here, I will correct the documentation. Its parameters do not meet specification. According to @Gregtom3, the author of this algorithm, defining a proper action function will take some refactoring.

The Iguana user guide includes a list of the actual action functions; the bottom of this front page also details what an action function is, exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Unsorted
Development

Successfully merging a pull request may close this issue.

2 participants