Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove burstsum references in QwHelicityPattern (after PR #156) #159

Open
wdconinc opened this issue Jun 12, 2019 · 0 comments
Open

Remove burstsum references in QwHelicityPattern (after PR #156) #159

wdconinc opened this issue Jun 12, 2019 · 0 comments
Assignees
@wdconinc @paulmking

Comments

@wdconinc
Copy link
Member

Environment: (where does this bug occur, have you tried other environments)

  • branch (master for latest released): feature-burst-outside-helicitypattern
  • revision (HEAD for most recent): HEAD
  • OS or system: Linux, gcc 8
  • Special ROOT or Geant4 versions? Nope

Steps to reproduce: (give a step by step account of how to trigger the bug)

  1. There are still references to burstsum/runningsum in QwHelicityPattern which are used externally (e.g. in QwParity):

    japan/Parity/include/QwHelicityPattern.h

    Line 79 in f737d9c

    /// Enable/disable burst sum calculation
  2. These should be removed. Questions: who is responsible for defining ProcessOptions related to print/enable burstsum/runningsum?
@wdconinc wdconinc self-assigned this Jun 12, 2019
@paulmking paulmking self-assigned this Nov 19, 2019
paulmking added a commit that referenced this issue Nov 19, 2019
@paulmking
Removing unneeded "Enable/Disable" functions from QwHelicityPattern.
e4252d4 
This largely resolves issue #159.

The QwHelicityPattern class is in charge of setting and using the flags to enable/disable analysis for:
    AlternateAsymmetry
    Burst
    RunningSum
    Difference
    Pairs
The QwHelicityPattern class had "Enable/Disable" functions and "Is*Enabled" functions for all of these, but almost none of them were meaningfully used.  I have removed almost all of them.
The "DisablePairs" function remains, as it is used when creating the summing copies of the QwHelicityPattern class for the full run and for bursts.
I have also temporarily left a commented copy of the "IsBurstSumEnabled" function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wdconinc wdconinc

@paulmking paulmking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wdconinc @paulmking