Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn of mismatch between helicity pattern size in config files and data stream #56

Open
paulmking opened this issue Jan 24, 2019 · 2 comments
Assignees

Comments

@paulmking
Copy link
Collaborator

If the size of the helicity pattern as used in the data stream is smaller than the size of the pattern the analyzer is expecting (for instance, the analyzer is trying to decode octets, but the data is in quartets), it will not provide any warnings, nor will it build valid pattern data.
We need to have a warning so we know we have a mismatch.

I'm pretty sure the contrary case will give a warning, but it should also be checked.

@paulmking paulmking self-assigned this Jan 24, 2019
@paulmking
Copy link
Collaborator Author

This can be tested with the mock data file by changing the PatternPhase setting in mock_qweak_helicity.map to either 2 (to expect pairs) or 8 (to expect octets). The mock data files seem to always be generated in quartets, so running qwparity on a mock file with parits or octents should give clear errors.

@paulmking
Copy link
Collaborator Author

It would probably be good to have the program exit after "a few" failures to find the type of pattern that was asked for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant