-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition from environment variables to parameter/configuration variables #7
Comments
Pull request #112 has specifically addressed the use of QW_DATA, but it likely also allows us to use configuration flags for all of the environment variables, in addition to having the environment variables. I'll check the functionality of the other variables later today. |
|
QW_TMP could probably be handled in a clever way as a QwOptions::GetTmpDir() which could be static (and QwOptions a singleton, which it isn't now if I recall). |
QwOptions is essentially already a singleton (since we interact with it through the global gQwOptions). Except we don't force it to be. Might be better to just implement it as a real singleton. |
Related: #115. That presents a solution for QW_TMP too, just replacing the getenv call with |
We should look at the list of environment variables we had used, and instead create parameter/configuration variables for things like raw data directory, rootfile output directory, etc.
Decide if it is useful to keep any of the environment variables.
Then either modify or remove the scripts in SetupFiles as appropriate.
It looks like the variables used from within the exisiting JAPAn are: QW_DATA, QW_ROOTFILES, QW_PRMINPUT, QW_TMP. The variables QW_FIELDMAP, QW_LOOKUP, and QW_SEARCHTREE were used by the QwTracking analysis, and so are not needed.
The text was updated successfully, but these errors were encountered: