Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Handling #75

Open
slominskir opened this issue Nov 5, 2024 · 1 comment
Open

Location Handling #75

slominskir opened this issue Nov 5, 2024 · 1 comment

Comments

@slominskir
Copy link
Member

slominskir commented Nov 5, 2024

This is an issue ticket to address Location handling as a whole as as there are a lot of issues to consider and they'll likely need to be addressed together:

Other Location filtering ideas to keep in mind:

  1. It may be useful to remember Location filter selection between web browsing sessions or at least during a single browsing session navigating between tabs (URL param vs cookie vs browser user storage)
  2. It may be useful to share Location filter selection between users (related: global Location filter: Add Dynamic Filter or Bulk Filter #36). Note: that may be overly complicated. We could just share the filtering parameters and avoid setup of a separate Kafka topic and avoid performing the actual filtering centrally. Note: if we DO do filtering centrally it must support multiple facilities / multiple new Kafka topics, one for each facility - advantage of client side is each client can do whatever based on what control room they're in.
  3. It may be useful to allow conditionally enabling Location inheritance. In JAWS locations are hierarchical, but also an alarm can be assigned multiple. An effort is made to avoid assigning alarms a location that is implied by an existing assigned location by virtue of inheritance. In other words only the most specific, non-overlapping locations should be assigned. The CED Sync for example automates this when examining SegMasks. The way Location filtering works at the moment is records from all Locations are included unless a non-empty filter is provided, in which case only the selected Locations are used when selecting records, but Location inheritance is used to include any child Locations implied by parent locations. This is probably most commonly what users want, but it does mean there is currently no way to ask to see records that have exactly a specific Location and excluding child Locations. Most notably there is no way at the moment to see Site-wide ONLY records because you can't indicate you want to disable inheritance, but also because you literally can't select the site-wide JLab root either: (related: Site-wide location unselectable #68).
  4. Keep in mind Location filtering appears in many tabs on the web app so updates may be spread wide
@slominskir
Copy link
Member Author

Note: When editing alarm locations via Inventory page form we could apply the same SegMask / Location squashing logic to avoid alarms with implied parent locations (as is already done via internal CED sync).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant