Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mute switch for plugin verifier #1646

Closed
abrooksv opened this issue Jun 7, 2024 · 7 comments
Closed

Add support for mute switch for plugin verifier #1646

abrooksv opened this issue Jun 7, 2024 · 7 comments
Assignees

Comments

@abrooksv
Copy link
Contributor

abrooksv commented Jun 7, 2024

Describe the need of your request

The latest release of the plugin verifier (https://github.com/JetBrains/intellij-plugin-verifier/releases/tag/1.367) added a -mute switch.

Can this be exposed as a ListProperty<String> on the verifier block?

Proposed solution

Add new provider on the verifier config

Alternatives you've considered

No response

Additional context

No response

@YannCebron
Copy link
Member

There's already https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-tasks.html#verifyPlugin-freeArgs which should work. I don't think it makes sense to expose this via dedicated property, given the total number of affected plugins.

@vsaar
Copy link

vsaar commented Jun 13, 2024

I tried to mute some errors with freeArgs, since my plugin has the intellij identifier in its name and title:

    verifyPlugin {
        ides {
            recommended()
        }
        freeArgs = listOf("-mute TemplateWordInPluginId,TemplateWordInPluginName")
    }

However, this results in the following error:

Exception in thread "main" java.lang.IllegalArgumentException: IDE must reside in a directory: <path-to-plugin>/build/distributions/plugin-1.11.0.zip
 	at com.jetbrains.pluginverifier.options.OptionsParser.createIdeDescriptor(OptionsParser.kt:103)
 	at com.jetbrains.pluginverifier.tasks.checkPlugin.DefaultIdeDescriptorParser.parseIdeDescriptors(CheckPluginParamsBuilder.kt:126)
 	at com.jetbrains.pluginverifier.tasks.checkPlugin.CheckPluginParamsBuilder.build(CheckPluginParamsBuilder.kt:41)
 	at com.jetbrains.pluginverifier.tasks.checkPlugin.CheckPluginParamsBuilder.build(CheckPluginParamsBuilder.kt:27)
 	at com.jetbrains.pluginverifier.PluginVerifierMain$main$3$1.invoke(PluginVerifierMain.kt:130)
 	at com.jetbrains.pluginverifier.PluginVerifierMain$main$3$1.invoke(PluginVerifierMain.kt:123)
 	at com.jetbrains.pluginverifier.tasks.profiling.PluginVerificationProfilingsKt.measurePluginVerification(PluginVerificationProfilings.kt:11)
 	at com.jetbrains.pluginverifier.PluginVerifierMain.main(PluginVerifierMain.kt:123)

The command line that is generated looks okay to me, so maybe it's an issue with the plugin verifier itself.

@abrooksv
Copy link
Contributor Author

@vsaar you need to split the list

        freeArgs = listOf(
            "-mute",
            "TemplateWordInPluginId"
        )

@vsaar
Copy link

vsaar commented Jun 21, 2024

@abrooksv, thanks, that worked. Though it's not very intuitive.

@YannCebron YannCebron self-assigned this Jul 2, 2024
@Macariel
Copy link

Macariel commented Aug 2, 2024

I just want to comment that the problem of not splitting up the single arguments leading to the error IDE must reside in directory has led me on the wildest goose chase.
This is probably a case of a problem not being caught at the right place and in combination with the inability to debug Gradle (in Intellij) and some outdated documentation (even though the plugin was just released), see downloadDirectory, which doesn't exist, leads to a very frustrating experience.

@abrooksv
Copy link
Contributor Author

abrooksv commented Aug 2, 2024

@Macariel You can usually debug gradle (as far as gradle is debuggable...) by enabling Gradle script debugging

Screenshot 2024-08-02 at 8 23 53 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants