From 45685c80da07c6541354f55ddbfc367a9a52accc Mon Sep 17 00:00:00 2001 From: Vladimir Mazunin Date: Thu, 7 Aug 2025 16:46:51 +0400 Subject: [PATCH 1/2] fixed adding a new library jsonreader (skjsonreader) --- .github/workflows/build.yml | 2 +- README.md | 8 ++++---- script/archive.py | 1 + 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 23eefc6..75792e8 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,7 +16,7 @@ permissions: contents: write env: - version: m138-c1caa59365c-1 + version: m138-c1caa59365c-2 jobs: macos: diff --git a/README.md b/README.md index c69679d..e5b5966 100644 --- a/README.md +++ b/README.md @@ -18,17 +18,17 @@ Prebuilt binaries can be found [in releases](https://github.com/JetBrains/skia-p Note: Better check build.yml for the detailed command for your machine ```sh -python3 script/checkout.py --version m138-9e6b5bff162 +python3 script/checkout.py --version m138-c1caa59365c python3 script/build.py -python3 script/archive.py --version m138-9e6b5bff162 +python3 script/archive.py --version m138-c1caa59365c ``` To build a debug build: ```sh -python3 script/checkout.py --version m138-9e6b5bff162 +python3 script/checkout.py --version m138-c1caa59365c python3 script/build.py --build-type Debug -python3 script/archive.py --version m138-9e6b5bff162 --build-type Debug +python3 script/archive.py --version m138-c1caa59365c --build-type Debug ``` ### Windows-specific diff --git a/script/archive.py b/script/archive.py index fb8037b..846ffa1 100755 --- a/script/archive.py +++ b/script/archive.py @@ -44,6 +44,7 @@ def main(): 'modules/skcms/*.h', 'modules/skunicode/include/*.h', 'modules/skunicode/src/*.h', + 'modules/jsonreader/*.h', 'src/base/*.h', 'src/core/*.h', 'src/gpu/ganesh/gl/*.h', From 528df5f9da2051910993eda103b702dc75fb5b27 Mon Sep 17 00:00:00 2001 From: Vladimir Mazunin Date: Thu, 7 Aug 2025 18:23:52 +0400 Subject: [PATCH 2/2] review fixes --- .github/workflows/build.yml | 2 +- README.md | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 75792e8..512ec01 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -16,7 +16,7 @@ permissions: contents: write env: - version: m138-c1caa59365c-2 + version: m138-9e6b5bff162-2 jobs: macos: diff --git a/README.md b/README.md index e5b5966..d0468da 100644 --- a/README.md +++ b/README.md @@ -14,21 +14,21 @@ Prebuilt binaries can be found [in releases](https://github.com/JetBrains/skia-p 3. Update `version` in [.github/workflows/build.yml](https://github.com/JetBrains/skia-pack/blob/master/.github/workflows/build.yml). ## Building locally - +Replace SKIA_VERSION with the version you want to build, for example `m138-9e6b5bff162`. Note: Better check build.yml for the detailed command for your machine ```sh -python3 script/checkout.py --version m138-c1caa59365c +python3 script/checkout.py --version SKIA_VERSION python3 script/build.py -python3 script/archive.py --version m138-c1caa59365c +python3 script/archive.py --version SKIA_VERSION ``` To build a debug build: ```sh -python3 script/checkout.py --version m138-c1caa59365c +python3 script/checkout.py --version SKIA_VERSION python3 script/build.py --build-type Debug -python3 script/archive.py --version m138-c1caa59365c --build-type Debug +python3 script/archive.py --version SKIA_VERSION --build-type Debug ``` ### Windows-specific