From 84e650d8869cb42a50ad154e5585a470c6adbd04 Mon Sep 17 00:00:00 2001
From: JhumanJ <julien@nahum.net>
Date: Thu, 15 Apr 2021 11:54:10 +0200
Subject: [PATCH] Fix dusk tests

---
 README.md                          | 1 +
 resources/js/components/Navbar.vue | 4 ++--
 resources/js/pages/welcome.vue     | 2 +-
 tests/Browser/LoginTest.php        | 1 +
 tests/Browser/Pages/Home.php       | 9 +++------
 tests/Browser/WelcomeTest.php      | 2 +-
 6 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index 211fb8504..44ec54d98 100644
--- a/README.md
+++ b/README.md
@@ -1,5 +1,6 @@
 # Laravel-Vue-Tailwind SPA 
 
+<a href="https://github.com/jhumanj/laravel-vue-tailwind-spa/actions"><img src="https://github.com/jhumanj/laravel-vue-tailwind-spa/workflows/tests/badge.svg" alt="Build Status"></a>
 <a href="https://packagist.org/packages/jhumanj/laravel-vue-tailwind-spa"><img src="https://poser.pugx.org/jhumanj/laravel-vue-tailwind-spa/d/total.svg" alt="Total Downloads"></a>
 <a href="https://packagist.org/packages/jhumanj/laravel-vue-tailwind-spa"><img src="https://poser.pugx.org/jhumanj/laravel-vue-tailwind-spa/v/stable.svg" alt="Latest Stable Version"></a>
 
diff --git a/resources/js/components/Navbar.vue b/resources/js/components/Navbar.vue
index da85979b9..9b7ee28fe 100644
--- a/resources/js/components/Navbar.vue
+++ b/resources/js/components/Navbar.vue
@@ -12,11 +12,11 @@
           <div class="ml-4 flex items-center md:ml-6">
             <div class="ml-3 relative">
               <div class="relative inline-block text-left">
-                <dropdown v-if="user">
+                <dropdown v-if="user" dusk="nav-dropdown">
                   <template #trigger="{toggle}">
                     <button type="button" @click.prevent="toggle()"
                             class="flex items-center justify-center w-full rounded-md  px-4 py-2 text-sm font-medium text-gray-700 dark:text-gray-50 hover:bg-gray-50 dark:hover:bg-gray-500 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-offset-gray-100 focus:ring-gray-500"
-                            id="options-menu">
+                            id="dropdown-menu-button" dusk="nav-dropdown-button">
                       <img :src="user.photo_url" class="rounded-full w-6 h-6">
                       <p class="ml-2">{{ user.name }}</p>
                     </button>
diff --git a/resources/js/pages/welcome.vue b/resources/js/pages/welcome.vue
index eb5a03111..a137926f5 100644
--- a/resources/js/pages/welcome.vue
+++ b/resources/js/pages/welcome.vue
@@ -1,7 +1,7 @@
 <template>
   <div>
     <div class="text-center">
-      <div class="text-6xl font-thin text-gray-500 mt-16 mb-8">
+      <div class="text-6xl font-thin text-gray-500 mt-16 mb-8" dusk="title">
         {{ title }}
       </div>
 
diff --git a/tests/Browser/LoginTest.php b/tests/Browser/LoginTest.php
index f69823ccc..b4b03c9bd 100644
--- a/tests/Browser/LoginTest.php
+++ b/tests/Browser/LoginTest.php
@@ -34,6 +34,7 @@ public function login_with_invalid_credentials()
         $this->browse(function ($browser) {
             $browser->visit(new Login)
                 ->submit('test@test.app', 'password')
+                ->pause(100)
                 ->assertSee('These credentials do not match our records.');
         });
     }
diff --git a/tests/Browser/Pages/Home.php b/tests/Browser/Pages/Home.php
index 7380d3918..d8421b29d 100644
--- a/tests/Browser/Pages/Home.php
+++ b/tests/Browser/Pages/Home.php
@@ -34,10 +34,7 @@ public function assert(Browser $browser)
      */
     public function elements()
     {
-        return [
-            '@dropdown-toggle' => '.navbar-nav.ml-auto .dropdown-toggle',
-            '@dropdown-menu' => '.dropdown-menu.show',
-        ];
+        return [];
     }
 
     /**
@@ -48,8 +45,8 @@ public function elements()
      */
     public function clickLogout($browser)
     {
-        $browser->click('@dropdown-toggle')
-            ->waitFor('@dropdown-menu')
+        $browser->click('@nav-dropdown-button')
+            ->waitFor('@nav-dropdown')
             ->waitForText('Logout')
             ->clickLink('Logout')
             ->pause(100);
diff --git a/tests/Browser/WelcomeTest.php b/tests/Browser/WelcomeTest.php
index 0be7ae85b..8d061d3f5 100644
--- a/tests/Browser/WelcomeTest.php
+++ b/tests/Browser/WelcomeTest.php
@@ -11,7 +11,7 @@ public function basic_test()
     {
         $this->browse(function ($browser) {
             $browser->visit('/')
-                ->waitFor('.title', 1)
+                ->waitFor('@title', 1)
                 ->assertSee('Laravel');
         });
     }