Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.
This repository was archived by the owner on May 6, 2024. It is now read-only.

Remove or extend UDP listening timeout #109

@fortuna

Description

@fortuna

If a read hits the timeout, we stop listening for packets:

proxyConn.SetDeadline(time.Now().Add(h.timeout))
n, addr, err := proxyConn.ReadFrom(buf)
if err != nil {
return
}

I wonder if this is causing issues with apps that use UDP, specially in extreme conditions.

The default timeout is 30 seconds:

udpHandler = oss.NewUDPHandler(t.client, 30*time.Second)

It's not clear to me that we need the timeout. Tun2socks stack will supposedly call udpHandler.Close() when the app socket is closed.

My suggestion is to remove the timeout. At least make is longer, like the 5 minutes we use on the server:
https://github.com/Jigsaw-Code/outline-ss-server/blob/8269318bb6268f9de5b289c31a59da7617520ce8/server.go#L50-L51

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions