Skip to content

Commit e7a5835

Browse files
authored
Clear compilation warnings (#121)
* Fix warnings of CMake To completely remove CMake version warnings, one may need to change the CMakeLists.txt file in the NDK installation. * Add compiler flag -Wpedantic Show compilation errors for the core subject, while ignore some of them
1 parent 8dff17c commit e7a5835

File tree

7 files changed

+17
-6
lines changed

7 files changed

+17
-6
lines changed

core/src/main/jni/CMakeLists.txt

+11-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
cmake_minimum_required(VERSION 3.8)
1+
cmake_minimum_required(VERSION 3.10)
22
project(core)
33

4+
set(CMAKE_CXX_STANDARD 23)
5+
46
add_subdirectory(${EXTERNAL_ROOT} external)
57

68
aux_source_directory(src SRC_LIST)
@@ -9,8 +11,16 @@ aux_source_directory(src/xz SRC_LIST)
911

1012
add_library(${PROJECT_NAME} STATIC ${SRC_LIST})
1113

14+
set(IGNORED_WARNINGS
15+
-Wno-c99-extensions
16+
-Wno-gnu-zero-variadic-macro-arguments
17+
-Wno-gnu-flexible-array-initializer
18+
-Wno-variadic-macros
19+
-Wno-zero-length-array)
20+
1221
target_include_directories(${PROJECT_NAME} PUBLIC include)
1322
target_include_directories(${PROJECT_NAME} PRIVATE src ${EXTERNAL_ROOT}/xz-embedded/linux/include)
23+
target_compile_options(${PROJECT_NAME} PRIVATE -Wpedantic ${IGNORED_WARNINGS})
1424

1525
target_link_libraries(${PROJECT_NAME} PUBLIC dobby_static lsplant_static xz_static log fmt-header-only)
1626
target_link_libraries(${PROJECT_NAME} PRIVATE dex_builder_static)

daemon/src/main/jni/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.8)
1+
cmake_minimum_required(VERSION 3.10)
22
project(daemon)
33

44
add_subdirectory(${EXTERNAL_ROOT} external)

dex2oat/src/main/cpp/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.8)
1+
cmake_minimum_required(VERSION 3.10)
22
project(dex2oat)
33

44
add_executable(dex2oat dex2oat.c)

external/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ set(XZ_SOURCES
109109
set(XZ_INCLUDES xz-embedded/linux/include/linux xz-embedded/userspace)
110110
list(TRANSFORM XZ_SOURCES PREPEND xz-embedded/linux/lib/xz/)
111111
add_library(xz_static STATIC ${XZ_SOURCES})
112+
target_compile_options(xz_static PRIVATE -DXZ_USE_CRC64)
112113
target_include_directories(xz_static PRIVATE ${XZ_INCLUDES})
113114

114115
link_libraries(cxx)

magisk-loader/src/main/jni/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.8)
1+
cmake_minimum_required(VERSION 3.10)
22
project(lspd)
33

44
add_subdirectory(${CORE_ROOT} core)

0 commit comments

Comments
 (0)