Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style – ESLint/Prettier/editorconfig #61

Open
macintoshhelper opened this issue May 10, 2020 · 0 comments
Open

Code style – ESLint/Prettier/editorconfig #61

macintoshhelper opened this issue May 10, 2020 · 0 comments

Comments

@macintoshhelper
Copy link
Collaborator

I think it may be worth deciding on an ESLint setup and using .editorconfig. Prettier seems to be bundled in with Gatsby, but I'm not a big fan of it personally, especially if it's not running in a pre-commit or in CI. But might be simplest just to agree on a prettierrc config, run it once throughout all the code, and enforce it in PRs.

Gatsby's prettierrc doesn't allow semicolons, which I'd suggest changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant