Add notification id to useMemo deps

JoinColony · Nov 28, 2024 · 729e56b · 729e56b
1 parent 9ec95d8
commit 729e56b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ons/UserHub/partials/NotificationsTab/partials/Notification/Action/ActionNotification.tsx b/...ons/UserHub/partials/NotificationsTab/partials/Notification/Action/ActionNotification.tsx
@@ -86,7 +86,7 @@ const ActionNotification: FC<NotificationProps> = ({
     }
 
     return formatText({ id: 'action.title' }, titleValues, notification.id);
-  }, [action, colony, titleValues]);
+  }, [action, colony, titleValues, notification.id]);
 
   const actionTitle =
     action?.metadata?.customTitle || action?.decisionData?.title || '';

diff --git a/...b/partials/NotificationsTab/partials/Notification/Expenditure/ExpenditureNotification.tsx b/...b/partials/NotificationsTab/partials/Notification/Expenditure/ExpenditureNotification.tsx
@@ -160,7 +160,7 @@ const ExpenditureNotification: FC<NotificationProps> = ({
       actionTitleValues,
       notification.id,
     );
-  }, [action, actionTitleValues, colony]);
+  }, [action, actionTitleValues, colony, notification.id]);
 
   return (
     <NotificationWrapper