-
Notifications
You must be signed in to change notification settings - Fork 15
[Advanced payment] Error displayed when uploading CSV file with more than 300 rows in advanced payment #3715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think the file you used as an example is missing the end-of-line semi-colon I think the validation in this case is actually correct |
I suspect the issue is related to the number of rows. I tested with two new CSV files, each containing more than 300 rows, and encountered the same problem. I corrected issue |
Hey @olgapod I have investigated the issue you have raised and we have a 400 rows limit, so the error shown in the modal is actually correct given the initial file contained Can you please check with this file? |
@olgapod these are already in Figma and Product specs - https://www.figma.com/design/5V8pr7iMwXsT9L3VAZsmUt/Actions-%26-Motions?node-id=3643-363169&t=4OcZPBL3fkJQ6eSD-4 |
So for this issue, we are actually not displaying the correct error message, which according to |
@mmioana can we approach this differently without the red alert box and instead, change the description in the modal (which is also incorrect) so this resolves two issues across all responsive sizes? Correct text: Bulk upload up to 400 recipients using a CSV. Use the template to ensure the correct structure, be sure to remove the sample data. |
@melyndav just to be sure I understood correctly, if there is an error due to the bulk size, we no longer display the error in the dropbox area and just update the description? |
We will still show an error if the upload fails, so that means that the error message needs to be updated as well |
Steps to reproduce
Expected behaviour
Actual behaviour
expenditures_batch (3).csv
The text was updated successfully, but these errors were encountered: