Skip to content

[Advanced payment] Error displayed when uploading CSV file with more than 300 rows in advanced payment #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olgapod opened this issue Nov 14, 2024 · 10 comments · Fixed by #4171
Assignees
Labels
bug Something isn't working Priority: P2 (Medium)

Comments

@olgapod
Copy link
Contributor

olgapod commented Nov 14, 2024

Steps to reproduce

  1. Open advanced payment.
  2. Try to upload the CSV file with more than 300 raws in attachment.

Expected behaviour

  • The CSV file should be uploaded successfully if it follows the correct structure

Actual behaviour

  • An error message appears indicating that the file structure is incorrect, preventing the upload.

expenditures_batch (3).csv

image
@olgapod olgapod added the bug Something isn't working label Nov 14, 2024
@rdig
Copy link
Member

rdig commented Nov 25, 2024

I think the file you used as an example is missing the end-of-line semi-colon

I think the validation in this case is actually correct

@olgapod olgapod changed the title [Advanced payment] Error displayed when uploading CSV file in advanced payment due to incorrect file structure [Advanced payment] Error displayed when uploading CSV file with more than 300 raws in advanced payment Jan 8, 2025
@olgapod
Copy link
Contributor Author

olgapod commented Jan 8, 2025

I suspect the issue is related to the number of rows. I tested with two new CSV files, each containing more than 300 rows, and encountered the same problem. I corrected issue

@mmioana mmioana self-assigned this Jan 15, 2025
@mmioana
Copy link
Contributor

mmioana commented Jan 15, 2025

Hey @olgapod I have investigated the issue you have raised and we have a 400 rows limit, so the error shown in the modal is actually correct given the initial file contained 658 payments
Screenshot 2025-01-15 at 13 28 00

Can you please check with this file?
expenditures_batch.3.1.csv
Btw I have updated the token address for ƓƓƓ and also the wallet address for rachel-racer

@olgapod
Copy link
Contributor Author

olgapod commented Jan 17, 2025

@mmioana Thanks for the comment.
@melyndav Should we change the validation message in this case to make it clear for a User?

@melyndav
Copy link

@mmioana
Copy link
Contributor

mmioana commented Jan 22, 2025

So for this issue, we are actually not displaying the correct error message, which according to Figma should be

Image

@melyndav
Copy link

@mmioana can we approach this differently without the red alert box and instead, change the description in the modal (which is also incorrect) so this resolves two issues across all responsive sizes?

Correct text: Bulk upload up to 400 recipients using a CSV. Use the template to ensure the correct structure, be sure to remove the sample data.

https://www.figma.com/design/5V8pr7iMwXsT9L3VAZsmUt/Actions-%26-Motions?node-id=22953-335854&t=4OcZPBL3fkJQ6eSD-4

@mmioana
Copy link
Contributor

mmioana commented Jan 22, 2025

@melyndav just to be sure I understood correctly, if there is an error due to the bulk size, we no longer display the error in the dropbox area and just update the description?

@rdig rdig changed the title [Advanced payment] Error displayed when uploading CSV file with more than 300 raws in advanced payment [Advanced payment] Error displayed when uploading CSV file with more than 300 rows in advanced payment Jan 24, 2025
@rdig
Copy link
Member

rdig commented Jan 24, 2025

We will still show an error if the upload fails, so that means that the error message needs to be updated as well

@melyndav
Copy link

@rdig I have given @mmioana the designs needed for the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority: P2 (Medium)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants