Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Codecs support? #21

Open
GrabbenD opened this issue Nov 22, 2023 · 3 comments
Open

[Question] Codecs support? #21

GrabbenD opened this issue Nov 22, 2023 · 3 comments

Comments

@GrabbenD
Copy link

Hey there

I love the idea of wrapping the web interface since I'd like to have a consistent UI between Android TV and my Linux Desktop without having to compile code every time I'd like to make minor changes to Jellyfin Web. This leads me to these questions:

  • How's the audio/video codecs support with this approach?
    • Is it identical to playing from a webbrowser?
    • Can you integrate MPV?

Would love to hear feedback from experienced users
@JonEllis

@JonEllis
Copy link
Owner

Hello. My use case was to mostly listen to music while gaining media key shortcut support - which has since worked from the browser. I've not used it in a little while, but from memory it worked just like using it in the web browser.
There might be ways to integrate further, I integrated with the player in the electron window to listen to change track events to show notifications - https://github.com/JonEllis/jellyfin-electron/blob/master/src/renderer/js/integration.js#L57-L63
I imagine it'd be possible to get the currently playing URL and pass it to MPV to play via the electron nodejs side - https://github.com/JonEllis/jellyfin-electron/blob/master/src/main.js#L58C2-L62C6.

@GrabbenD
Copy link
Author

@JonEllis Thank you for the insights!

I'm planning to give it a shot today.
I came across this project which has hooks for integrating MPV playback support when creating the browser instance: https://github.com/Kagami/mpv.js/

Let's hope it goes smoothly 🙏

@GrabbenD
Copy link
Author

My intention was to create a cross platform app with bundled Chromium to avoid inconsistencies with native components & to not re-create the interface.. However, it looks like Electron is mainly just for desktop apps. There's another project for this called Crosswalk from Intel but it's discontinued.

@JonEllis While reading your blog I noticed you mentioned iOS. Did you actually manage to get this Electron app running on your phone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants