Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Export types #531

Open
3 tasks done
joel-daros opened this issue Jun 12, 2024 · 3 comments
Open
3 tasks done

馃殌 Feature: Export types #531

joel-daros opened this issue Jun 12, 2024 · 3 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@joel-daros
Copy link

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

I鈥檓 testing console-fail-test in one of our projects within our monorepo.
Our Vitest env is configured using a single vitest.config file pointing to a setupTest.ts file inside each monorepo project, so I can鈥檛 change the shared vitest config, because it will affect all projects.

Note that my setupTest.ts is a TS file, so when I鈥檓 importing console-fail-test TS is complaining about missing declaration types for this package:

As a workaround I had to add a couple of TS and Eslint ignores to bypass this issue:

// setupTest.ts

// @ts-expect-error console-fail-test is not exporting types
import { cft } from "console-fail-test";

// eslint-disable-next-line @typescript-eslint/no-unsafe-call
cft();

Additional Info

No response

@joel-daros joel-daros added the type: feature New enhancement or request label Jun 12, 2024
@JoshuaKGoldberg
Copy link
Owner

Ah, I would have thought this would have already been done by #209. Definitely a bug that should be fixed. Thanks for filing!

@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Jun 16, 2024
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @joel-daros for ideas.

馃 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 馃挋

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @joel-daros! 馃帀

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this issue Jun 17, 2024
Adds @joel-daros as a contributor for ideas.

This was requested by JoshuaKGoldberg [in this
comment](#531 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

2 participants