馃洜 Tooling: Unnecessary commitType: docs in .all-contributorsrc #1090
Labels
area: tooling
Managing the repository's maintenance
status: accepting prs
Please, send a pull request to resolve this!
type: cleanup
Tech debt or other code/repository cleanups
Bug Report Checklist
main
branch of the repository.Overview
Thanks to #1048, we see now that this repository has two bits of tooling that are different between its 馃崕 actual files and 馃崒 code templates (see Additional Info below for explanation of the emojis):
"commitType": "docs"
:create-typescript-app/.all-contributorsrc
Line 367 in d66379b
"commitType": "docs"
:create-typescript-app/src/steps/writing/creation/writeAllContributorsRC.ts
Line 10 in d66379b
Docs for
commitType
are being added in all-contributors/all-contributors#710 -> all-contributors/all-contributors#757. Seems that the default value is"docs"
. So there's no need to explicitly specify it the way this repo has been.Let's remove any and all references to
commitType
from this repo. Accepting PRs!Additional Info
This repository is two things:
For the most part, the repository's end-to-end test for
--mode migration
makes sure that the 馃崕 actual files and 馃崒 code templates stay the same. As in, if one changes, the other needs to have the same change as well. But per #546, there are some files that were missed in that test. We're only now able to verify that they're the same as of #1048. That PR is where this discrepancy was discovered.The text was updated successfully, but these errors were encountered: