diff --git a/DESCRIPTION b/DESCRIPTION index 55f9dac..4bfe9e3 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,5 +1,6 @@ Package: sfdep Title: Spatial Dependence for Simple Features + Version: 0.2.4 Authors@R: c( person("Josiah", "Parry", , "josiah.parry@gmail.com", role = c("aut"), @@ -7,6 +8,7 @@ Authors@R: c( person("Dexter", "Locke", 'H', "dexter.locke@gmail.com", role = c("aut", "cre"), comment = c(ORCID = "0000-0003-2704-9720")) ) + Description: An interface to 'spdep' to integrate with 'sf' objects and the 'tidyverse'. License: GPL-3 URL: https://sfdep.josiahparry.com, https://github.com/josiahparry/sfdep diff --git a/NEWS.md b/NEWS.md index 72336c1..8d00e7e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,10 @@ +# sfdep 0.2.5 + +- updated spacetime_constructor to comply with updates to the cli package. No user-facing changes + # sfdep 0.2.4 -- Dexter Locke is now the maintainer of sfdep +- Dexter Locke [@DHLocke] is now the maintainer of sfdep - Address failing CRAN checks h/t [@rsbivand](https://github.com/rsbivand) - Address bug in local Gi/* statistics diff --git a/R/spacetime-constructor.R b/R/spacetime-constructor.R index eeeacc4..bdeb31b 100644 --- a/R/spacetime-constructor.R +++ b/R/spacetime-constructor.R @@ -176,8 +176,8 @@ validate_spacetime <- function(.data, .geometry, .loc_col, .time_col) { if (!identical(.data_loc_class, .geo_loc_class)) { cli::cli_abort( c("Differing class types for {.var .loc_col}.", - i = "{.var .data}: {.cls {.data_loc_class}}", - "i" = "{.var .geometry}: {.cls {.geo_loc_class}}.") + i = "{.var .data}: {.cls {(.data_loc_class)}}", + "i" = "{.var .geometry}: {.cls {(.geo_loc_class)}}.") ) } diff --git a/cran-comments.md b/cran-comments.md index 1f13685..aa060f2 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,8 +1,5 @@ ## R CMD check results -0 errors | 0 warnings | 0 note +Package was archived yesterday, 2023-01-09, despite efforts to address outstanding issues. -* This release removes myself (Josiah Parry) as the maintainer and makes - Dexter Locke the new maintainer of sfdep. - * CRAN has been notified of this in previous correspondence via email -* Addresses failing noSuggests checks +Latest submission failed the recursive `noSuggest` check. An example using an imported package (sf) failed because the imported function (sf::read_sf) used a suggested package (tibble suggested by sf). All instances of `sf::read_sf()` have been changed to `sf::st_read()` which, I believe, does not use any suggested packages. diff --git a/tests/testthat/test-spacetime-constructor_cli_update_patch.R b/tests/testthat/test-spacetime-constructor_cli_update_patch.R new file mode 100644 index 0000000..e8efd65 --- /dev/null +++ b/tests/testthat/test-spacetime-constructor_cli_update_patch.R @@ -0,0 +1,12 @@ +test_that("local_g_perm", { + df_fp <- system.file("extdata", "bos-ecometric.csv", package = "sfdep") + geo_fp <- system.file("extdata", "bos-ecometric.geojson", package = "sfdep") + + # read in data + df <- read.csv( + df_fp, colClasses = c("numeric", "character", "integer", "double", "Date") + ) + + geo <- sf::st_read(geo_fp) + expect_error(spacetime(df, geo, ".region_id", "year")) +})