Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests now fail #18

Closed
ablaom opened this issue Jan 11, 2024 · 2 comments
Closed

Tests now fail #18

ablaom opened this issue Jan 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ablaom
Copy link
Member

ablaom commented Jan 11, 2024

With no change in this repo since the last release, tests are failing locally for me.

An analysis suggests the culprit is LinearSVC:

using Pkg
Pkg.activate(temp=true)
Pkg.add("MLJBase")
Pkg.add("MLJLIBSVMInterface")

using MLJLIBSVMInterface, MLJBase

X, y = @load_iris
model = MLJLIBSVMInterface.LinearSVC()

mach = machine(model, X, y)
fit!(mach)

# [ Info: Training machine(LinearSVC(solver = L2R_L2LOSS_SVC_DUAL, …), …).
# ┌ Error: Problem fitting the machine machine(LinearSVC(solver = L2R_L2LOSS_SVC_DUAL, …), …).
# └ @ MLJBase ~/.julia/packages/MLJBase/xcS6N/src/machines.jl:683
# [ Info: Running type checks...
# [ Info: Type checks okay.
# ERROR: Please check your parameters: Initial-solution specification supported only for solvers L2R_LR, L2R_L2LOSS_SVC, and L2R_L2LOSS_SVR
# Stacktrace:
#   [1] error(s::String)
#     @ Base ./error.jl:35
#   [2] linear_train(labels::Vector{…}, instances::LinearAlgebra.Adjoint{…}; weights::Nothing, solver_type::Int32, eps::Float64, C::Float64, p::Float64, init_sol::Ptr{…}, bias::Float64,
# verbose::Bool)
#     @ LIBLINEAR ~/.julia/packages/LIBLINEAR/77yny/src/LIBLINEAR.jl:227
@ablaom ablaom added the bug Something isn't working label Jan 11, 2024
@ablaom
Copy link
Member Author

ablaom commented Jan 28, 2024

It seems a fix will be provided by

@vovw
Copy link

vovw commented Jan 7, 2025

this is solved and can be closed

@ablaom ablaom closed this as completed Jan 8, 2025
@github-project-automation github-project-automation bot moved this from priority high / straightforward to Done in General Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants