Improves tests. Fixes imports (#35)

* Improves tests. Fixes imports

* Make 1.8 the minimum julia requirement (can't wait for new LTS)

* CI: Julia 1.8

Author: Azzaare

.github/workflows/CI.yml

@@ -50,7 +50,7 @@ jobs:
       fail-fast: false
       matrix:
         version:
-          - "1.7"
+          - "1.8"
           - "1"
           - "pre"
         os:

.gitignore

@@ -5,4 +5,8 @@
 /docs/build/
 /docs/Manifest.toml
 
-/perf/Manifest.toml
+/perf/Manifest.toml
+
+.gitignore
+
+.DS_Store

Project.toml

@@ -11,12 +11,14 @@ TestItems = "1c621080-faea-4a02-84b6-bbd5e436b8fe"
 Dictionaries = "0.4"
 TestItemRunner = "0.2, 1"
 TestItems = "0.1, 1"
-julia = "1.7"
+julia = "1.8"
 
 [extras]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
+ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
+JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 TestItemRunner = "f8b46487-2199-4994-9208-9a1283c18c0a"
 
 [targets]
-test = ["Aqua", "Test", "TestItemRunner"]
+test = ["Aqua", "ExplicitImports", "JET", "Test", "TestItemRunner"]

src/ConstraintCommons.jl

@@ -1,8 +1,8 @@
 module ConstraintCommons
 
 #!SECTION -- Imports
-using Dictionaries
-using TestItems
+import Dictionaries: AbstractDictionary, Dictionary, set!
+import TestItems: @testitem
 
 #!SECTION -- Exports
 

src/nothing.jl

@@ -15,6 +15,7 @@ consisempty(::Nothing) = true
 consisempty(items) = @inline isempty(items)
 
 @testitem "Set: nothing" tags=[:set, :nothing] begin
-    @test !(ConstraintCommons.consin(42, nothing))
-    @test ConstraintCommons.consisempty(nothing)
+    import ConstraintCommons: consin, consisempty
+    @test !(consin(42, nothing))
+    @test consisempty(nothing)
 end

src/symbols.jl

@@ -8,5 +8,6 @@ function symcon(s1::Symbol, s2::Symbol, connector::AbstractString = "_")
 end
 
 @testitem "Symbols" tags=[:symbols] begin
-    @test ConstraintCommons.symcon(:a, :b) === :a_b
+    import ConstraintCommons: symcon
+    @test symcon(:a, :b) === :a_b
 end

test/Aqua.jl

@@ -1,8 +1,4 @@
 @testset "Aqua.jl" begin
-    import Aqua
-    import ConstraintCommons
-    import Dictionaries
-
     # TODO: Fix the broken tests and remove the `broken = true` flag
     Aqua.test_all(
         ConstraintCommons;

test/ExplicitImports.jl

@@ -0,0 +1,3 @@
+@testset "Look for Explicit Imports" begin
+    @test check_no_implicit_imports(ConstraintCommons) === nothing
+end

test/JET.jl

@@ -0,0 +1,3 @@
+@testset "Code linting (JET.jl)" begin
+    JET.test_package(ConstraintCommons; target_defined_modules = true)
+end

test/runtests.jl

@@ -1,7 +1,14 @@
+using ConstraintCommons
+
+using Aqua
+using ExplicitImports
+using JET
 using Test
 using TestItemRunner
 
 @testset "Package tests: ConstraintCommons" begin
     include("Aqua.jl")
+    include("ExplicitImports.jl")
+    include("JET.jl")
     include("TestItemRunner.jl")
 end