Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tail to avoid clash with Base.tail #2261

Closed
cossio opened this issue May 17, 2020 · 5 comments · Fixed by #2262
Closed

Rename tail to avoid clash with Base.tail #2261

cossio opened this issue May 17, 2020 · 5 comments · Fixed by #2262
Labels
breaking The proposed change is breaking.
Milestone

Comments

@cossio
Copy link

cossio commented May 17, 2020

I typically import Base: tail into scope. If I then do using DataFrames, I get a warning

WARNING: using DataFrames.tail in module Main conflicts with an existing identifier.

Although Base.tail is not exported, it is documented (https://docs.julialang.org/en/v1/base/collections/#Base.tail) and I think many people use it regularly.

To avoid this clash, maybe DataFrames can use a different name for this function? Or it could just extend Base.tail.

@cossio cossio changed the title Rename tail to avoid possible clash with Base.tail? Rename tail to avoid possible clash with Base.tail May 17, 2020
@bkamins
Copy link
Member

bkamins commented May 17, 2020

see #2262

@bkamins bkamins added the breaking The proposed change is breaking. label May 17, 2020
@bkamins bkamins added this to the 1.0 milestone May 17, 2020
@cossio cossio changed the title Rename tail to avoid possible clash with Base.tail Rename tail to avoid clash with Base.tail May 17, 2020
@cossio
Copy link
Author

cossio commented Sep 7, 2020

@bkamins Any estimate of when this change will be released? I keep getting annoying bugs / warnings because of this (end up calling the wrong tail).

@bkamins
Copy link
Member

bkamins commented Sep 7, 2020

Well - we could make a release now as we have enough functionality to justify it, but users wanted to postpone the release to make sure we include all breaking things in 0.22 and there are several loose ends related to select/transform/combine that need working out and might lead to breakage.

CC @oxinabox @nalimilan

@oxinabox
Copy link
Contributor

oxinabox commented Sep 7, 2020

I would really like hold off on release until we are done.
Its much easier to batch up upgrading literally dozens of packages.

@bkamins
Copy link
Member

bkamins commented Sep 7, 2020

Just as a reference #2410 and #2314 (and related) are major pain points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking The proposed change is breaking.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants