Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error due to integer overflow being fixed in base julia #124

Open
pdeffebach opened this issue Dec 1, 2020 · 2 comments
Open

Error due to integer overflow being fixed in base julia #124

pdeffebach opened this issue Dec 1, 2020 · 2 comments

Comments

@pdeffebach
Copy link
Contributor

There is a WIP PR here to fix some error with bounds checking in SkipMissing. When that is merged we should port the same fix to SkipMissings
@FedericoStra
Copy link

FedericoStra commented Dec 2, 2020 •
edited
Loading

With the latest commit in the PR I'm trying to address this issue too.

As I mentioned in a comment in the PR, there is a small performance problem with _mapreduce for SkipMissing, which was already present. I haven't done anything to solve it in that regard.

@FedericoStra
Copy link

Ooops! I'm realizing now that this is an issue in another project 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FedericoStra @pdeffebach