Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107 and fixes #109 by using
copyto!
instead ofunsafe_copyto!
.Additionally, I fixed type stability of
getindex
and support for emptyChainedVector
s.Currently on the main branch:
With this PR:
I don't see any performance regression with this PR in the benchmark in #105, on the contrary probably due to the type inference fixes the PR reduces the number of allocations:
Currently on the main branch:
With this PR: