Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push! type piracy #94

Closed
adienes opened this issue Dec 18, 2023 · 3 comments · Fixed by #102
Closed

push! type piracy #94

adienes opened this issue Dec 18, 2023 · 3 comments · Fixed by #102

Comments

@adienes
Copy link

adienes commented Dec 18, 2023

@inline Base.push!(buffer::T, x::S) where {T,S} = push!(buffer, convert(T, x))

I think the piracy here should be avoided if possible. I noticed this when the error message for something like push!(0, 0) changed

@ancapdev
Copy link

I hit this today. To type pirate an function as core as Base.push!() seems rather presumptuous.

@quinnj
Copy link
Member

quinnj commented May 17, 2024

@Drvi, would you mind fixing this? Otherwise, I can try to fix today

@Drvi
Copy link
Contributor

Drvi commented May 17, 2024

Ah I see what is going on, I'll make a PR shortly. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants