-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix argmax, findmax, findXwithfirst, and expand testing #99
Merged
Merged
Changes from 21 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
0ba1041
Fix argmin and argmax
gdalle 9851910
Revert bqd fix
gdalle 628839b
Add two small tests
gdalle 01396a1
Moar tests to figure out what's wrong
gdalle 64f2a78
Fix tests
gdalle 5dcebff
Fix comparison order
gdalle b400f6f
Add more vectors to test and test vectors
mkitti 926a899
last fix
gdalle 0178dde
One comp only
gdalle 1b0ad53
Add tests
mkitti 3fcc45f
Merge branch 'findmaxmin'
mkitti 487e6b1
Improve test set
mkitti b5a923f
Integrate test suggestions by @Seelengrab
mkitti ba21bf1
Fix argmax tests with function
mkitti 36f6278
Fix findmax
mkitti 5391fd1
Test collect
mkitti 29f77e4
Run some tests only on 1.6 or greater
mkitti 30c86bd
Fix static if
mkitti 5ff3d7f
Add more tests
mkitti 3a6f915
Update chainedvector.jl
mkitti 7775ac5
Update src/chainedvector.jl
mkitti eee286e
Update test/chainedvector.jl
mkitti 750cb8f
Revert back to approx in sum test
mkitti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a hard-coded set of test vectors, could a few 1000 be generated when the test runs? That might catch a few more edge cases.
Also, I think it would be clearer to only test
Int
here, to avoidNaN
and floating point rounding.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is part of @Seelengrab 's Supposition.jl is supposed to do. I'm just trying to get this pull request through before I start messing with adding test dependencies, but we seem to be stuck here.