-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables API enhancement #131
Changes from 4 commits
0e3ea80
4cf8f0b
74e303e
7f790aa
97fb679
5de2ed5
26b7d93
6e18a29
4611bb3
cd93aab
d3bf9d5
dc438ef
3c549d4
f32bd2e
8bdd327
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,32 @@ | ||
# Documentation: http://docs.travis-ci.com/user/languages/julia/ | ||
language: julia | ||
os: | ||
- linux | ||
- osx | ||
- windows | ||
arch: | ||
- x64 | ||
- x86 | ||
julia: | ||
- 1.0 | ||
- 1.1 | ||
- 1.3 | ||
- nightly | ||
matrix: | ||
allow_failures: | ||
- julia: nightly | ||
fast_finish: true | ||
exclude: | ||
- os: osx | ||
arch: x86 | ||
include: | ||
- stage: "Documentation" | ||
julia: 1.3 | ||
os: linux | ||
script: | ||
- julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate(); Pkg.build("Tables")' | ||
- julia --project=docs/ docs/make.jl | ||
after_success: skip | ||
notifications: | ||
email: false | ||
after_success: | ||
- julia -e 'using Pkg; Pkg.add("Coverage"); using Coverage; Codecov.submit(process_folder())' | ||
- julia -e 'ENV["TRAVIS_JULIA_VERSION"] == "1.3" && ENV["TRAVIS_OS_NAME"] != "linux" && exit(); using Pkg; Pkg.add("Coverage"); using Coverage; Codecov.submit(Codecov.process_folder())' |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[deps] | ||
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" | ||
|
||
[compat] | ||
Documenter = "~0.23" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
using Documenter, Tables | ||
|
||
makedocs(; | ||
modules=[Tables], | ||
format=Documenter.HTML(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't necessary AFAIK. Same for |
||
pages=[ | ||
"Home" => "index.md", | ||
], | ||
repo="https://github.com/JuliaData/Tables.jl/blob/{commit}{path}#L{line}", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this needed? It's not set up in other packages I know, and the link works. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is all generated from PkgTemplates.jl There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we got a bit overzealous? Example.jl is much simpler: https://github.com/JuliaLang/Example.jl/blob/master/docs/make.jl |
||
sitename="Tables.jl", | ||
authors="Jacob Quinn", | ||
assets=String[], | ||
) | ||
|
||
deploydocs(; | ||
repo="github.com/JuliaData/Tables.jl", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's recommended to specify a particular version to avoid breakage. Then the Manifest isn't needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manifest is useful becaue then you can include in it
which makes sure the docstrings are right for the dev version docs.