Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate is not increasing the order of the underlying Taylor1 #334

Open
rcalxrc08 opened this issue Sep 16, 2023 · 1 comment
Open

Integrate is not increasing the order of the underlying Taylor1 #334

rcalxrc08 opened this issue Sep 16, 2023 · 1 comment

Comments

@rcalxrc08
Copy link

Noticed by @dpsanders What about the integration? Should we increase the order? and still open.

using TaylorSeries
x_fl=1.0
max_order=20
x=taylor_expand(identity,x_fl,order=max_order)
y=exp(x)
der=derivative(y)
@assert get_order(der)==max_order-1 #Correct the derivative is consuming one order.
y_reconstructed=integrate(der,exp(x_fl))
@assert get_order(y_reconstructed)==max_order #assertion error, the integral is not adding one order

To be noticed that if integrate was actually reconstructing the order, one could implement easily but not efficiently any function for Taylor1.

@lbenet
Copy link
Member

lbenet commented Sep 24, 2023

Sorry for the late response...

I see your point and somewhat agree with it (at least, I haven't been able to construct an example where increasing the order yields a wrong answer). It is not complicated to implement this for Taylor1, but trickier for TaylorN where there is a maximum order.

Give me some more time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants